Added Policy State Getters #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhruv-Mishra
changed the title
kopy-kat
approved these changes
Jan 23, 2025
| userOpSender, | ||
| }: { | ||
| client: PublicClient | ||
| configId: bigint |
There was a problem hiding this comment.
we could also just accept this as a hex or is there a reason you're not doing this?
There was a problem hiding this comment.
I just thought bigint would be the default way here.
Will update this to only include Hex
There was a problem hiding this comment.
Should I enforce configId being a Byte32 Hex or write functions to automatically extend any Hex argument to Hex32 or is it not required?
There was a problem hiding this comment.
I dont think its required here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Policy State Getters for the policies defined here
Related to issue: #109