-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option of only using Account Address in some methods #113
Added option of only using Account Address in some methods #113
Conversation
looks good - could you please make sure the tests are passing before me merge |
it looks like it fails on |
(see the gh action) |
Yes, just checked the logs, will push a commit to fix this |
Updated the index to include the newly defined function, awaiting workflow approval |
still failing - you should be able to repro locally by running |
The build now works fine locally, awaiting workflow approval |
lgtm |
Adopting suggestions from from #67
Since TS Types and Interfaces do no exist at runtime, added a custom Typeguard for Account Object Verification. (Reference: https://www.typescriptlang.org/docs/handbook/advanced-types.html)
Alternatively, if modification to the definition Account is allowed, a custom tag or a new property can be added to the account to verify it's type.
Ran npm test, along with self written unit tests to verify that all related tests pass successfully.