Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network module raises Exception on command failure issue 51 #97

Merged
merged 1 commit into from
Jan 16, 2018
Merged

network module raises Exception on command failure issue 51 #97

merged 1 commit into from
Jan 16, 2018

Conversation

myakove
Copy link

@myakove myakove commented Dec 20, 2017 •
edited by lukas-bednar
Loading

Fixes #51

@myakove myakove force-pushed the network-raises-CommandExecutionFailure-issue51 branch from 1ecc7a6 to d1effd4 Compare December 20, 2017 15:49
@codecov-io
Copy link

codecov-io commented Dec 20, 2017 •
edited
Loading

Codecov Report

Merging #97 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #97      +/-   ##
=========================================
+ Coverage   75.59%   75.6%   +0.01%     
=========================================
  Files          17      17              
  Lines        1520    1521       +1     
=========================================
+ Hits         1149    1150       +1     
  Misses        371     371
Impacted Files Coverage Δ
rrmngmnt/network.py 71.86% <33.33%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 397793f...298c30a. Read the comment docs.

@myakove
Copy link
Author

myakove commented Dec 20, 2017

fix #51

@lukas-bednar lukas-bednar added this to the 0.1.14 milestone Jan 2, 2018
lukas-bednar
lukas-bednar reviewed Jan 2, 2018
View reviewed changes
Copy link
Member

@lukas-bednar lukas-bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is raising Exception on line 131 as well

@myakove myakove force-pushed the network-raises-CommandExecutionFailure-issue51 branch from d1effd4 to 298c30a Compare January 2, 2018 09:33
@lukas-bednar
Copy link
Member

LGTM!

@lukas-bednar lukas-bednar merged commit 32f356a into rhevm-qe-automation:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukas-bednar lukas-bednar lukas-bednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@myakove @codecov-io @lukas-bednar