Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UserWithPKey instead of pkey parameter #144

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Use UserWithPKey instead of pkey parameter #144

merged 1 commit into from
Apr 20, 2021

Conversation

lukas-bednar
Copy link
Member

Fixes: #23

Signed-off-by: Lukas Bednar [email protected]

@lukas-bednar lukas-bednar force-pushed the issue_23 branch 2 times, most recently from b80fca7 to 9f240eb Compare April 20, 2021 08:35
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #144 (d4528ca) into master (341ddcf) will increase coverage by 0.04%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   80.65%   80.70%   +0.04%     
==========================================
  Files          19       19              
  Lines        1949     1969      +20     
==========================================
+ Hits         1572     1589      +17     
- Misses        377      380       +3     
Impacted Files Coverage Δ
rrmngmnt/__init__.py 100.00% <ø> (ø)
rrmngmnt/host.py 68.14% <ø> (ø)
rrmngmnt/ssh.py 34.56% <55.55%> (+1.45%) ⬆️
rrmngmnt/user.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 341ddcf...d4528ca. Read the comment docs.

@rnetser
Copy link

rnetser commented Apr 20, 2021

LGTM

1 similar comment
@myakove
Copy link

myakove commented Apr 20, 2021

LGTM

@lukas-bednar
Copy link
Member Author

I managed to verify this particular case locally:

DEBUG:RemoteExecutor:[[email protected]//home/lbednar/.ssh/cnv-qe-jenkins.key] Results of command: uname -a
DEBUG:RemoteExecutor:[[email protected]//home/lbednar/.ssh/cnv-qe-jenkins.key]   OUT: Linux lbednar-centos-test 3.10.0-957.1.3.el7.x86_64 #1 SMP Thu Nov 29 14:49:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

@lukas-bednar lukas-bednar added this to the 0.1.27 milestone Apr 20, 2021
@lukas-bednar lukas-bednar merged commit 87686bc into master Apr 20, 2021
@lukas-bednar lukas-bednar deleted the issue_23 branch April 20, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to specify path to public key to use for ssh auth
3 participants