Added support for the 'bridge' command. #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a function in the network module for retrieving bridges data using the 'bridge' command. This is necessary since the 'brctl' command which is used in the current bridge related methods is no longer supported by RHEL 8.x.
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 79.47% 79.52% +0.04%
==========================================
Files 19 19
Lines 1837 1841 +4
==========================================
+ Hits 1460 1464 +4
Misses 377 377
Continue to review full report at Codecov.
|
MosheSheena
requested review from
KwisatzHaderach,
lukas-bednar,
myakove and
kobihk
kobihk
approved these changes
Feb 3, 2020
|
@lukas-bednar hi can we merge? |
myakove
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function in the network module for retrieving
bridges data using the 'bridge' command.
This is necessary since the 'brctl' command which is used
in the current bridge related methods is no longer supported
by RHEL 8.x.