Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to multiple json libraries #46

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

Quiwin
Copy link

@Quiwin Quiwin commented Oct 9, 2020

Add support for multiple JSON coder using MultiJson

Hello again from Klaxit!
We need to be able to choose internally which JSON encoder is to be used, MultiJson is generally the most popular solution 🙂 .

@Quiwin Quiwin marked this pull request as ready for review October 9, 2020 15:50
@BuonOmo BuonOmo self-assigned this Oct 27, 2020
Copy link
Member

@BuonOmo BuonOmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keithdoggett I guess this could even go in a patch version since for people using JSON it won't change anything.
Maybe a minor just to warn users that if they are using any other json lib such as Oj they have a minor chance of encountering floating point issues (Oj < 3.10.4 ohler55/oj#583).

@BuonOmo BuonOmo assigned keithdoggett and unassigned BuonOmo Oct 27, 2020
@keithdoggett
Copy link
Member

Looks good to me as well.

@BuonOmo I agree that we could handle it as a patch, but I think a minor version is better because of the issue you pointed out and because a dependency is being added.

I also want to link these PRs #29 and #38 and explain why this isn't just a reversion to old behavior. There used to be an option to use different parsers and would require the parser at runtime. This was deprecated in favor of just using the standard parser.

The solution here is different because the APIstays the same and all of the parser selection is handled in multi_json which will use the standard parser by default.

@keithdoggett keithdoggett merged commit 7316c96 into rgeo:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants