Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard lib json parser is good enough - and this definitely shouldn't be a required parameter.
And then, it swallows the error? Doesn't make sense to me. Frankly, to me, this entire bit should be removed and you should just parse with the standard lib if you get a string (ruby < 1.9 can figure it out themselves - particularly if there was an error thrown - oh wait, you require 1.9.3 so that doesn't even matter).
But in the interest of not making a major modification - it's already checking the type, why raise an error if it's a string? Why not just make life better and just work?