Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output spam | Hide debug messages #171

Closed
hakavlad opened this issue Mar 7, 2020 · 3 comments
Closed

Output spam | Hide debug messages #171

hakavlad opened this issue Mar 7, 2020 · 3 comments

Comments

@hakavlad
Copy link
Contributor

hakavlad commented Mar 7, 2020 •
edited
Loading

Is it necessary to log every minute? It makes the journal less readable. The background checking can run as frequently as possible, but it would be nice if it logged very rarely when there's enough free memory, and increased the interval when the memory is getting filled up. When I have 80% of memory free, such frequent logging seems superfluous. Or is just debugging feature that will get turned off on F32 final release?

https://pagure.io/fedora-workstation/issue/119#comment-631173

In fact, option -r is a debug option.

I think memory reports should be disabled by default.

I think

EARLYOOM_ARGS="-r 0 -m 4 -M 500000"

is good default.
@rfjakob
Copy link
Owner

rfjakob commented Mar 7, 2020

No i like the memory report, fedora can set it to 0 if they want.

@rfjakob rfjakob closed this as completed Mar 7, 2020
@kparal
Copy link

kparal commented Mar 9, 2020

I didn't ask for disabling the messages completely, but for being considerably less frequent when there's no memory pressure.

@hakavlad
Copy link
Contributor Author

hakavlad commented Mar 16, 2020 •
edited
Loading

I've tested earlyoom with F32 beta on special VM with 2 GB RAM within a week and earlyoom pushed tons of garbage to journald.

https://pagure.io/fedora-workstation/issue/119#comment-633658

@hakavlad hakavlad mentioned this issue Mar 21, 2020
Closed
rfjakob added a commit that referenced this issue Mar 22, 2020
@rfjakob
earlyoom.default: set -r 3600
e1c74d9 
As there have now been two complaints about the default
log output being too noisy, I'll have to accept that
other users find the memory reports less interesting
than I do :)

Increase from 60 seconds to 3600 seconds (one memory
report per hour)

#171
#177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rfjakob @kparal @hakavlad