Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved typing and grouping #686

Merged
merged 1 commit into from
Feb 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/data/revogr-data.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ export class RevogrData {
...rgRow,
index: rgRow.itemIndex,
model: dataItem,
groupingCustomRenderer: groupingCustomRenderer,
groupingCustomRenderer,
hasExpand: this.columnService.hasGrouping,
providers: this.providers,
};
Expand Down
1 change: 1 addition & 0 deletions src/plugins/groupingRow/grouping.row.plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import {
TRIMMED_GROUPING,
} from './grouping.trimmed.service';

export * from './grouping.const';
export * from './grouping.row.expand.service';
export * from './grouping.row.types';
export * from './grouping.service';
Expand Down
1 change: 1 addition & 0 deletions src/plugins/groupingRow/grouping.row.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ interface GroupTemplateProp {
export type GroupLabelTemplateFunc = (
createElement: HyperFunc<VNode>,
props: GroupTemplateProp,
...args: any[]
) => any;

export type GroupingOptions = {
Expand Down
2 changes: 1 addition & 1 deletion src/utils/column.utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function getCellData(val?: any) {
return val;
}

export function getCellRaw(model: DataType, column?: ColumnRegular) {
export function getCellRaw(model: DataType = {}, column?: ColumnRegular) {
if (!column) {
return;
}
Expand Down
Loading