use fixed staticcheck version #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
shmokmt
commented
Oct 25, 2024
•
shmokmt
commented
- close Do not use latest staticcheck version (or/and support specifying staticcheck version) #17
- an example PR: chore(deps): update staticcheck to 2024.1.1 #65
shmokmt
changed the title
shmokmt
force-pushed
the
do-not-use-latest-staticcheck
branch
from
afbd8a7 to
e167bbe
Compare
shmokmt
force-pushed
the
do-not-use-latest-staticcheck
branch
2 times, most recently
from
0856fd8 to
786a1ce
Compare
shmokmt
commented
Oct 25, 2024
| @@ -32,3 +32,29 @@ jobs: | |||
| branch: depup/reviewdog | |||
| base: master | |||
| labels: "bump:minor" | |||
|
|
|||
| staticcheck: | |||
There was a problem hiding this comment.
Since there are too many parameters, it seemed difficult to write them all together using a GitHub Actions matrix 💦
In this case, It's better to write naively.
shmokmt
changed the title
|
@kstiehl |
shmokmt
commented
Oct 25, 2024
| @@ -7,13 +7,15 @@ TEMP_PATH="$(mktemp -d)" | |||
| PATH="${TEMP_PATH}:$PATH" | |||
| export REVIEWDOG_GITHUB_API_TOKEN="${INPUT_GITHUB_TOKEN}" | |||
|
|
|||
| STATICCHECK_VERSION="2024.1.1" | |||
There was a problem hiding this comment.
This is the latest version
https://github.com/dominikh/go-tools/releases
|
Will do later today |
kstiehl
approved these changes
Oct 26, 2024
haya14busa
reviewed
Jan 26, 2025
| echo '::endgroup::' | ||
|
|
||
|
|
||
| echo '::group:: Running staticcheck with reviewdog 🐶 ...' | ||
| staticcheck ${INPUT_STATICCHECK_FLAGS} -f=json ${INPUT_TARGET:-.} \ | ||
| staticcheck "${INPUT_STATICCHECK_FLAGS}" -f=json "${INPUT_TARGET:-.}" \ |
There was a problem hiding this comment.
Please unquote INPUT_STATICCHECK_FLAGS and INPUT_TARGET.
Space in these env vars should be treated as-is.
You can ignore shellcheck warning.
| @@ -22,7 +24,7 @@ staticcheck ${INPUT_STATICCHECK_FLAGS} -f=json ${INPUT_TARGET:-.} \ | |||
| -filter-mode="${INPUT_FILTER_MODE}" \ | |||
| -fail-on-error="${INPUT_FAIL_ON_ERROR}" \ | |||
| -level="${INPUT_LEVEL}" \ | |||
| ${INPUT_REVIEWDOG_FLAGS} | |||
| "${INPUT_REVIEWDOG_FLAGS}" | |||
Yes, of course! |
shmokmt
added a commit
that referenced
this pull request
Jan 27, 2025
Space in these env vars should be treated as-is #64 (comment)
Merged
|
@haya14busa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.