Support related locations #55

haya14busa · 2024-06-09T12:19:53Z

github-actions · 2024-06-09T12:20:17Z

🏷️ [bumpr] Next version:v1.19.0 Changes:v1.18.1...reviewdog:support-related-locations

github-actions · 2024-06-17T13:56:30Z

testdata/testdata.go

@@ -21,7 +21,7 @@ func unused() {
 	regexp.Compile(".\\")


🚫 [staticcheck] <S1007> _{reported by reviewdog 🐶}
should use raw string (...) with regexp.Compile to avoid having to escape twice

github-actions · 2024-06-17T13:56:30Z

testdata/testdata.go

@@ -21,7 +21,7 @@
 	regexp.Compile(".\\")


🚫 [staticcheck] <SA1000> _{reported by reviewdog 🐶}
error parsing regexp: trailing backslash at end of expression: ``

github-actions · 2024-06-17T13:56:30Z

testdata/testdata.go

@@ -21,7 +21,7 @@
 	regexp.Compile(".\\")

 	s := []string{}
-	if s != nil {
+	if s != nil { // test


🚫 [staticcheck] <S1031> _{reported by reviewdog 🐶}
unnecessary nil check around range

github-actions · 2024-06-17T13:56:30Z

testdata/testdata.go

@@ -21,7 +21,7 @@
 	regexp.Compile(".\\")

 	s := []string{}
-	if s != nil {
+	if s != nil { // test


🚫 [staticcheck] <SA4031> _{reported by reviewdog 🐶}
this nil check is always true

this is the value of s

action-staticcheck/testdata/testdata.go

Line 23 in 5d4d6a7

s := []string{}

github-actions · 2024-06-17T13:57:37Z

testdata/testdata.go

@@ -12,6 +12,8 @@ const (
 )

 func unused() {


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
func unused is unused

github-actions · 2024-06-17T13:57:37Z

testdata/testdata.go

@@ -12,6 +12,8 @@
 )

 func unused() {
+	s := []string{}
+
 	regexp.Compile(".+")

 	if errors.New("abcd") == errors.New("abcd") {


🚫 [staticcheck] <SA9003> _{reported by reviewdog 🐶}
empty branch

github-actions · 2024-06-17T13:57:37Z

testdata/testdata.go

@@ -20,8 +22,7 @@

 	regexp.Compile(".\\")

-	s := []string{}
-	if s != nil {
+	if s != nil { // test


🚫 [staticcheck] <SA4031> _{reported by reviewdog 🐶}
this nil check is always true

this is the value of s

action-staticcheck/testdata/testdata.go

Line 15 in d5c274f

s := []string{}

github-actions · 2024-06-17T14:03:03Z

testdata/testdata.go

 	if errors.New("abcd") == errors.New("abcd") {
 		// Test SA4000
 	}

 	regexp.Compile(".\\")

 	s := []string{}
-	if s != nil {
+	if s != nil { // test


🚫 [staticcheck] <SA4031> _{reported by reviewdog 🐶}
this nil check is always true

this is the value of s

action-staticcheck/testdata/testdata.go

Line 25 in e1c729d

s := []string{}

github-actions · 2024-06-17T14:03:03Z

testdata/testdata.go

 		for _, x := range s {
 			fmt.Println(x)
 		}
 	}
+
+	if nonNilVar != nil {


🚫 [staticcheck] <SA4031> _{reported by reviewdog 🐶}
this nil check is always true

this is the value of nonNilVar

action-staticcheck/testdata/testdata.go

Line 17 in e1c729d

nonNilVar := []int{}

github-actions · 2024-06-17T14:45:38Z

testdata/testdata.go

 	if errors.New("abcd") == errors.New("abcd") {
 		// Test SA4000
 	}

 	regexp.Compile(".\\")

 	s := []string{}
-	if s != nil {
+	if s != nil { // test


🚫 [staticcheck] <SA4031> _{reported by reviewdog 🐶}
this nil check is always true

this is the value of s

action-staticcheck/testdata/testdata.go

Line 25 in 97409ba

s := []string{}

github-actions · 2024-06-17T14:45:38Z

testdata/testdata.go

 		for _, x := range s {
 			fmt.Println(x)
 		}
 	}
+
+	if nonNilVar != nil {


🚫 [staticcheck] <SA4031> _{reported by reviewdog 🐶}
this nil check is always true

this is the value of nonNilVar

action-staticcheck/testdata/testdata.go

Line 17 in 97409ba

nonNilVar := []int{}

github-actions · 2024-06-22T13:38:56Z

testdata/testdata.go

@@ -14,16 +14,22 @@ const (
 func unused() {


🚫 [staticcheck] <U1000> _{reported by reviewdog 🐶}
func unused is unused

github-actions · 2024-06-22T13:38:56Z

testdata/testdata.go

@@ -14,16 +14,22 @@
 func unused() {
 	regexp.Compile(".+")

+	nonNilVar := []int{}
+
 	if errors.New("abcd") == errors.New("abcd") {


🚫 [staticcheck] <SA9003> _{reported by reviewdog 🐶}
empty branch

github-actions · 2024-06-22T13:38:56Z

testdata/testdata.go

@@ -14,16 +14,22 @@
 func unused() {
 	regexp.Compile(".+")

+	nonNilVar := []int{}
+
 	if errors.New("abcd") == errors.New("abcd") {
 		// Test SA4000
 	}

 	regexp.Compile(".\\")


🚫 [staticcheck] <S1007> _{reported by reviewdog 🐶}
should use raw string (...) with regexp.Compile to avoid having to escape twice

github-actions · 2024-06-22T13:38:57Z

testdata/testdata.go

@@ -14,16 +14,22 @@
 func unused() {
 	regexp.Compile(".+")

+	nonNilVar := []int{}
+
 	if errors.New("abcd") == errors.New("abcd") {
 		// Test SA4000
 	}

 	regexp.Compile(".\\")


🚫 [staticcheck] <SA1000> _{reported by reviewdog 🐶}
error parsing regexp: trailing backslash at end of expression: ``

github-actions · 2024-06-22T13:38:57Z

testdata/testdata.go

 	if errors.New("abcd") == errors.New("abcd") {
 		// Test SA4000
 	}

 	regexp.Compile(".\\")

 	s := []string{}
-	if s != nil {
+	if s != nil { // test


🚫 [staticcheck] <S1031> _{reported by reviewdog 🐶}
unnecessary nil check around range

github-actions · 2024-06-22T13:38:57Z

testdata/testdata.go

 	if errors.New("abcd") == errors.New("abcd") {
 		// Test SA4000
 	}

 	regexp.Compile(".\\")

 	s := []string{}
-	if s != nil {
+	if s != nil { // test


🚫 [staticcheck] <SA4031> _{reported by reviewdog 🐶}
this nil check is always true

this is the value of s

action-staticcheck/testdata/testdata.go

Line 25 in 9a21890

s := []string{}

github-actions · 2024-06-22T13:38:57Z

testdata/testdata.go

 		for _, x := range s {
 			fmt.Println(x)
 		}
 	}
+
+	if nonNilVar != nil {


🚫 [staticcheck] <SA4031> _{reported by reviewdog 🐶}
this nil check is always true

this is the value of nonNilVar

action-staticcheck/testdata/testdata.go

Line 17 in 9a21890

nonNilVar := []int{}

github-actions · 2024-06-22T13:42:50Z

🚀 [bumpr] Bumped! New version:v1.19.0 Changes:v1.18.2...v1.19.0

depup workflow has been broken by #55 I fixed it.

haya14busa added the bump:minor label Jun 9, 2024

haya14busa added 2 commits June 17, 2024 22:55

Support related locations

6edaf72

test with nightly

ad7ea01

haya14busa force-pushed the support-related-locations branch from 1f2f48c to ad7ea01 Compare June 17, 2024 13:55

update test data

5d4d6a7

github-actions bot reviewed Jun 17, 2024

View reviewed changes

haya14busa force-pushed the support-related-locations branch 2 times, most recently from 623092f to 131a777 Compare June 17, 2024 14:01

Update test data

e1c729d

haya14busa force-pushed the support-related-locations branch from 131a777 to e1c729d Compare June 17, 2024 14:02

github-actions bot reviewed Jun 17, 2024

View reviewed changes

Bump up reviewdog version to v0.18.0

97409ba

github-actions bot reviewed Jun 17, 2024

View reviewed changes

haya14busa marked this pull request as ready for review June 17, 2024 14:45

Bump up reviewdog version to v0.18.1

9a21890

github-actions bot reviewed Jun 22, 2024

View reviewed changes

empty commit

081d68c

haya14busa merged commit 7ee91d0 into master Jun 22, 2024
6 checks passed

shogo82148 added a commit that referenced this pull request Jun 28, 2024

fix depup workflow

ef0972d

depup workflow has been broken by #55 I fixed it.

shogo82148 mentioned this pull request Jun 28, 2024

fix depup workflow #58

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support related locations #55

Support related locations #55

haya14busa commented Jun 9, 2024

github-actions bot commented Jun 9, 2024

github-actions bot Jun 17, 2024

github-actions bot Jun 17, 2024

github-actions bot Jun 17, 2024

github-actions bot Jun 17, 2024

github-actions bot Jun 17, 2024

github-actions bot Jun 17, 2024

github-actions bot Jun 17, 2024

github-actions bot Jun 17, 2024

github-actions bot Jun 17, 2024

github-actions bot Jun 17, 2024

github-actions bot Jun 17, 2024

github-actions bot Jun 22, 2024

github-actions bot Jun 22, 2024

github-actions bot Jun 22, 2024

github-actions bot Jun 22, 2024

github-actions bot Jun 22, 2024

github-actions bot Jun 22, 2024

github-actions bot Jun 22, 2024

github-actions bot commented Jun 22, 2024

Support related locations #55

Support related locations #55

Conversation

haya14busa commented Jun 9, 2024

github-actions bot commented Jun 9, 2024

github-actions bot Jun 17, 2024

Choose a reason for hiding this comment

github-actions bot Jun 17, 2024

Choose a reason for hiding this comment

github-actions bot Jun 17, 2024

Choose a reason for hiding this comment

github-actions bot Jun 17, 2024

Choose a reason for hiding this comment

github-actions bot Jun 17, 2024

Choose a reason for hiding this comment

github-actions bot Jun 17, 2024

Choose a reason for hiding this comment

github-actions bot Jun 17, 2024

Choose a reason for hiding this comment

github-actions bot Jun 17, 2024

Choose a reason for hiding this comment

github-actions bot Jun 17, 2024

Choose a reason for hiding this comment

github-actions bot Jun 17, 2024

Choose a reason for hiding this comment

github-actions bot Jun 17, 2024

Choose a reason for hiding this comment

github-actions bot Jun 22, 2024

Choose a reason for hiding this comment

github-actions bot Jun 22, 2024

Choose a reason for hiding this comment

github-actions bot Jun 22, 2024

Choose a reason for hiding this comment

github-actions bot Jun 22, 2024

Choose a reason for hiding this comment

github-actions bot Jun 22, 2024

Choose a reason for hiding this comment

github-actions bot Jun 22, 2024

Choose a reason for hiding this comment

github-actions bot Jun 22, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 22, 2024