Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement action-staticcheck #1

Merged
merged 11 commits into from
May 10, 2020
Merged

Implement action-staticcheck #1

merged 11 commits into from
May 10, 2020

Conversation

haya14busa
Copy link
Member

No description provided.

| reviewdog -efm="%f:%l:%c: %m" \
-name="linter-name (misspell)" \
-reporter="${INPUT_REPORTER:-github-pr-check}" \
staticcheck ${INPUT_STATICCHECK_FLAGS} -f=json ${INPUT_TARGET:-.} \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

| reviewdog -efm="%f:%l:%c: %m" \
-name="linter-name (misspell)" \
-reporter="${INPUT_REPORTER:-github-pr-check}" \
staticcheck ${INPUT_STATICCHECK_FLAGS} -f=json ${INPUT_TARGET:-.} \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

"regexp"
)

func unused() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[staticcheck] reported by reviewdog 🐶
func unused is unused U1000

func unused() {
regexp.Compile(".+")

if errors.New("abc") == errors.New("abc") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[staticcheck] reported by reviewdog 🐶
empty branch SA9003

func unused() {
regexp.Compile(".+")

if errors.New("abc") == errors.New("abc") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[staticcheck] reported by reviewdog 🐶
identical expressions on the left and right side of the '==' operator SA4000

)

const (
First byte = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[staticcheck] reported by reviewdog 🐶
only the first constant in this group has an explicit type SA9004

@haya14busa
Copy link
Member Author

image

@github-actions
Copy link
Contributor

🏷️ [bumpr] Next version:v1.0.0

@haya14busa haya14busa merged commit f7b2de4 into master May 10, 2020
@haya14busa haya14busa deleted the init branch May 10, 2020 10:32
@github-actions
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant