feat(window): expose a few more window-options #968
Conversation
|
I have updated your lock dirs and formatted the code. |
lessp
changed the title
|
I'm not sure what to do about the transparency-flag. I think it makes sense to expose it for full opacity, but perhaps we should name it something else as to reserve it for pure background-transparency? |
src/Core/WindowCreateOptions.re
Outdated
| @@ -72,10 +84,13 @@ let create = | |||
| ~maximized=false, | |||
| ~decorated=true, | |||
| ~titlebarStyle=WindowStyles.System, | |||
| ~transparency=1.0, | |||
There was a problem hiding this comment.
This sets the opacity, not transparency, which is its inverse. Fully transparent means it's see-through, while fully opaque means it's solid.
There was a problem hiding this comment.
Ah, that's true! Switch our naming to opacity and leave a comment perhaps?
There was a problem hiding this comment.
Updated, let me know if you think we're good to go!
Since it's associated with the window, I don't think it''s a problem. Background transparency would instead be associated with painting I think. |
Co-authored-by: Glenn Slotte <[email protected]>
Co-authored-by: Glenn Slotte <[email protected]>
Co-authored-by: Glenn Slotte <[email protected]>
Co-authored-by: Glenn Slotte <[email protected]>
Co-authored-by: Glenn Slotte <[email protected]>
Co-authored-by: Glenn Slotte <[email protected]>
Thanks for reviewing and the suggested changes @glennsl! |
| // Sdl2 has this named as Transparency, but it actually works as opacity | ||
| // where a value of 1.0 means it's fully opaque | ||
| Sdl2.Window.setTransparency(sdlWindow, options.opacity); |
There was a problem hiding this comment.
SDL2 actually has it right. It's reason-sdl that gets it wrong. And since reason-sdl is in this repo we could fix it completely in this PR.
| /** | ||
| [opacity] sets the opacity of the window. | ||
| A value of 1.0 means the window is fully opaque, | ||
| and a value of 0.0 means the window is completely transparent. | ||
| */ |
This adds a
transparency-option to Window.EDIT: I guess though, that this puts a transparency on everything, not only the "background-window" as you'd expect. 🤔
Would close #506