Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: support remote images #642

Closed
wants to merge 73 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
c1f1093
Update to latest brisk-reconciler
bryphe Sep 28, 2019
783e46b
Add override for simple-component-api branch
bryphe Sep 28, 2019
adec991
Add reference to PPX
bryphe Sep 28, 2019
e5cdc2f
Convert UI_Primitives to Brisk component PPX
wokalski Oct 1, 2019
78cf54e
First pass at converting UI_Components to Brisk ppx
wokalski Oct 1, 2019
6c1c0da
chore: convert examples and some components
lessp Oct 1, 2019
8ad88c5
chore: begin conversion to latest brisk-reconciler
lessp Oct 27, 2019
63207ea
refactor: can't use %component for stateless components
lessp Oct 27, 2019
0b82605
refactor: update examples
lessp Oct 27, 2019
18872e6
refactor: just working through type-errors
lessp Oct 27, 2019
433e9e4
chore: use listToElement
lessp Oct 27, 2019
c943d58
refactor: dropdown-example setState takes callback
lessp Oct 27, 2019
eeb274b
fix: update missed hook-calls
lessp Oct 27, 2019
5c7a51b
chore: at least it builds
lessp Oct 28, 2019
cf179a8
chore: lock-files, formatting
lessp Oct 28, 2019
1bacffe
Fix dropdown
Et7f3 Oct 29, 2019
4137dba
Fix RadioButton
Et7f3 Oct 29, 2019
075d67f
Fix FontExample
Et7f3 Oct 29, 2019
f7e1399
chore: merge master locally
lessp Oct 29, 2019
3f7b937
refactor: fixes and updates after merge
lessp Oct 29, 2019
e26ad43
chore(Input): fix unused variable-warning
lessp Oct 29, 2019
afab3be
chore(Input): it was a duplicate, hence the warning..
lessp Oct 29, 2019
b28ec28
chore: fix warning in OpenGLExample
lessp Oct 29, 2019
552854a
docs: animation-example fix after merge
lessp Oct 30, 2019
0d7adea
fix: fonts and radiobuttons-example
lessp Oct 30, 2019
24564ad
chore: merge master locally
lessp Oct 31, 2019
c3b689e
docs: update Todo to latest brisk-reconciler
lessp Oct 31, 2019
c94d774
hacky remote image-renderer
lessp Nov 3, 2019
eaa8460
chore: merge master
lessp Nov 3, 2019
6c16524
refactor: update transition and Input-example
lessp Nov 3, 2019
5a4fc3c
fix: Input due to no default tabindex in Clickable
lessp Nov 3, 2019
57feee6
chore: lockfiles, package.json
lessp Nov 3, 2019
b293b4f
refactor: update interface-files
lessp Nov 3, 2019
639c68a
refactor: button and checkbox-interfaces
lessp Nov 3, 2019
1baf6ad
refactor: button checkbox interface-files
lessp Nov 3, 2019
255e596
chore: add back window.setTitle
lessp Nov 3, 2019
74d4cc8
chore: add back misses in examples when converting
lessp Nov 3, 2019
245f46f
chore: get tests running again
lessp Nov 3, 2019
1db0231
chore: update brisk-reconciler version in js.json
lessp Nov 3, 2019
4c68021
fix: bug in Container rendering-logic
lessp Nov 3, 2019
9516740
refactor: update interface files per review
lessp Nov 3, 2019
42c073b
chore: update lock-files
lessp Nov 3, 2019
b225f60
open Revery_UI.{React.Hooks,Animated}, add buildDev. Part-revert 245f46f
Et7f3 Nov 3, 2019
4579355
Fix doc comments.
Et7f3 Nov 3, 2019
5fcf658
Fix rei don't access internal module__.
Et7f3 Nov 3, 2019
8e157f0
chore: formatting
lessp Nov 3, 2019
8167d9c
Remove buildDev because it break the CI.
Et7f3 Nov 3, 2019
6b596ae
chore: merge locally
lessp Nov 4, 2019
d2af78e
refactor: bit less hacky remote-image
lessp Nov 7, 2019
7427ce9
chore: add todos
lessp Nov 8, 2019
17c1c51
refactor: use Revery_Fetch
lessp Nov 8, 2019
a47c9dc
chore: remove unecessary module assignment
lessp Nov 10, 2019
56e6c33
chore: remove module assignment
lessp Nov 10, 2019
20ead3a
chore: use released version of fetch-core
lessp Nov 10, 2019
bba6868
chore: add fetch-core as npm-dependency
lessp Nov 10, 2019
0a4d2ce
chore: use option-utils
lessp Nov 10, 2019
3fae6fd
chore: merge master locally
lessp Nov 10, 2019
cb0c1c5
chore: integrate recent changes from master
lessp Nov 10, 2019
409b67b
chore: merge with latest component-ppx
lessp Nov 10, 2019
27f4db3
chore: clarify return value
lessp Nov 11, 2019
0c38095
chore: merge master locally
lessp Nov 11, 2019
37d70ec
chore: merge master locally
lessp Nov 13, 2019
6938251
refactor: try to remove noise
lessp Nov 13, 2019
d7b6a17
chore: lock-files
lessp Nov 13, 2019
159eb08
chore: merge master locally
lessp Nov 14, 2019
eea99b5
chore: update to latest revery
lessp Nov 15, 2019
8c40c78
chore: lockfiles
lessp Nov 15, 2019
a5be1be
chore: merge master locally
lessp Nov 20, 2019
6e78930
chore: lockfiles
lessp Nov 20, 2019
65f6dbc
refactor: remove utils-module
lessp Nov 23, 2019
fa9ea7b
refactor: use fetch-native-lwt
lessp Nov 23, 2019
bb2bfe9
chore: merge master locally
lessp Nov 23, 2019
9b3a7e1
chore: update lock-files
lessp Nov 23, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: update missed hook-calls
  • Loading branch information
lessp committed Oct 27, 2019
commit eeb274b937b6513b8b58dc8d1cb436925696e975
2 changes: 1 addition & 1 deletion examples/Hello.re
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ let logo = {
),
);

let%hook (rotationY, hooks) =
let%hook rotationY =
Hooks.animation(
Animated.floatValue(0.),
Animated.options(
Expand Down
3 changes: 2 additions & 1 deletion examples/InputExample.re
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ module Example = {
};

let%component make = () => {
let ({first, second}, setValue) = Hooks.state({first: "", second: ""});
let%hook ({first, second}, setValue) =
Hooks.state({first: "", second: ""});

<View style=containerStyle>
<View
Expand Down
4 changes: 2 additions & 2 deletions examples/ScreenCapture.re
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ module ActionButton = {

module CaptureArea = {
let%component make = (~w, ()) => {
let (count, setCount) = Hooks.state(0);
let (file, setFile) = Hooks.state(None);
let%hook (count, setCount) = Hooks.state(0);
let%hook (file, setFile) = Hooks.state(None);

let capture = () => {
let exed = Environment.getExecutingDirectory();
Expand Down
2 changes: 1 addition & 1 deletion examples/ScrollView.re
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ let innerBox =

module Sample = {
let%component make = () => {
let (bounce, setBounce) = Hooks.state(true);
let%hook (bounce, setBounce) = Hooks.state(true);

<View style=containerStyle>
<Text
Expand Down
35 changes: 16 additions & 19 deletions examples/ZoomExample.re
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module ZoomButton = {
};

module Zoom = {
let%component make = ((), hooks) => {
let%component make = () => {
let window = UI.getActiveWindow();
let zoomV =
switch (window) {
Expand Down Expand Up @@ -45,24 +45,21 @@ module Zoom = {

print_endline("Zoomv: " ++ string_of_float(currentZoom));

(
hooks,
<Center>
<Column>
<Text
style=textStyle
text={"Zoom: " ++ string_of_float(currentZoom)}
/>
<Row>
<ZoomButton zoom=0.5 onClick=setZoom />
<ZoomButton zoom=1.0 onClick=setZoom />
<ZoomButton zoom=1.25 onClick=setZoom />
<ZoomButton zoom=1.5 onClick=setZoom />
<ZoomButton zoom=2.0 onClick=setZoom />
</Row>
</Column>
</Center>,
);
<Center>
<Column>
<Text
style=textStyle
text={"Zoom: " ++ string_of_float(currentZoom)}
/>
<Row>
<ZoomButton zoom=0.5 onClick=setZoom />
<ZoomButton zoom=1.0 onClick=setZoom />
<ZoomButton zoom=1.25 onClick=setZoom />
<ZoomButton zoom=1.5 onClick=setZoom />
<ZoomButton zoom=2.0 onClick=setZoom />
</Row>
</Column>
</Center>;
};
};

Expand Down