Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab order on grouping preferences page #781

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Fix tab order on grouping preferences page #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Change log

## Development version

### Bug fixes

- The tab order of controls on the Grouping tab on the playlist view preferences
page was corrected. [[#781](https://github.com/reupen/columns_ui/pull/781)]

## 2.1.0-beta.3

### Bug fixes
Expand Down
14 changes: 7 additions & 7 deletions foo_ui_columns/foo_ui_columns.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,19 +372,19 @@ STYLE DS_SETFONT | DS_CONTROL | WS_CHILD
EXSTYLE WS_EX_CONTROLPARENT
FONT 8, "Tahoma", 0, 0, 0x0
BEGIN
CONTROL "Show groups",IDC_GROUPING,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,7,30,57,10
PUSHBUTTON "Move up",IDC_GROUP_UP,7,251,50,14
PUSHBUTTON "Move down",IDC_GROUP_DOWN,60,251,50,14
PUSHBUTTON "New...",IDC_GROUP_NEW,217,251,50,14
PUSHBUTTON "Delete",IDC_GROUP_DELETE,270,251,50,14
LTEXT "Grouping",IDC_TITLE1,7,4,307,16
CONTROL "Show groups",IDC_GROUPING,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,7,30,57,10
CONTROL "Indent each level of grouping",IDC_INDENT_GROUPS,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,7,48,121,10
CONTROL "Use a custom amount of indentation:",IDC_USE_CUSTOM_INDENTATION,
"Button",BS_AUTOCHECKBOX | WS_TABSTOP,7,66,137,10
EDITTEXT IDC_INDENTATION_AMOUNT,147,64,40,14,ES_AUTOHSCROLL
CONTROL "",IDC_INDENTATION_AMOUNT_SPIN,"msctls_updown32",UDS_SETBUDDYINT | UDS_ALIGNRIGHT | UDS_AUTOBUDDY | UDS_ARROWKEYS | UDS_NOTHOUSANDS,199,65,12,10
LTEXT "px",-1,189,67,9,8
LTEXT "Groups",IDC_H2_TITLE,7,89,313,13
CONTROL "Use a custom amount of indentation:",IDC_USE_CUSTOM_INDENTATION,
"Button",BS_AUTOCHECKBOX | WS_TABSTOP,7,66,137,10
PUSHBUTTON "Move up",IDC_GROUP_UP,7,251,50,14
PUSHBUTTON "Move down",IDC_GROUP_DOWN,60,251,50,14
PUSHBUTTON "New...",IDC_GROUP_NEW,217,251,50,14
PUSHBUTTON "Delete",IDC_GROUP_DELETE,270,251,50,14
END

IDD_PREFS_FILTER_FIELDS DIALOGEX 0, 0, 327, 271
Expand Down
1 change: 1 addition & 0 deletions foo_ui_columns/ng_playlist/ng_playlist_prefs_groups.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ BOOL GroupsPreferencesTab::ConfigProc(HWND wnd, UINT msg, WPARAM wp, LPARAM lp)
case WM_INITDIALOG: {
m_wnd = wnd;
m_groups_list_view.create(wnd, {7, 105, 313, 140}, true);
SetWindowPos(m_groups_list_view.get_wnd(), GetDlgItem(wnd, IDC_H2_TITLE), 0, 0, 0, 0, SWP_NOMOVE | SWP_NOSIZE);

LOGFONT font{};
GetObject(GetWindowFont(wnd), sizeof(font), &font);
Expand Down