Merge pull request #1082 from reupen/dialogue-titles

Make dialogue titles more stylistically consistent
reupen · Jan 19, 2025 · fb75d5b · fb75d5b
2 parents 7f88bbb + 4d9386e
commit fb75d5b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
 # Change log
 
-## Development version
+## 3.0.0-alpha.2
 
 ### Bug fixes
 
@@ -12,6 +12,9 @@
   code generator dialogue box title was fixed.
   [[#1076](https://github.com/reupen/columns_ui/pull/1076)]
 
+- Some stylistic inconsistencies in dialogue box titles were fixed.
+  [[#1082](https://github.com/reupen/columns_ui/pull/1082)]
+
 - A nicer error message is now logged to the console when using $set_font() with
   a non-existent font family name.
   [[#1081](https://github.com/reupen/columns_ui/pull/1081)]

diff --git a/foo_ui_columns/foo_ui_columns.rc b/foo_ui_columns/foo_ui_columns.rc
@@ -191,7 +191,7 @@ END
 
 IDD_SPECTRUM_ANALYSER_OPTIONS DIALOGEX 0, 0, 202, 145
 STYLE DS_SETFONT | DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU
-CAPTION "Options - Spectrum Analyser"
+CAPTION "Options – Spectrum analyser"
 FONT 8, "Segoe UI", 400, 0, 0x0
 BEGIN
     DEFPUSHBUTTON   "OK",IDOK,83,124,50,14
@@ -208,7 +208,7 @@ END
 
 IDD_BUTTON_COMMAND_PICKER DIALOGEX 0, 0, 326, 364
 STYLE DS_SETFONT | DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU
-CAPTION "Select a command"
+CAPTION "Select a command – Buttons"
 FONT 8, "Segoe UI", 400, 0, 0x0
 BEGIN
     DEFPUSHBUTTON   "OK",IDOK,207,343,50,14
@@ -224,7 +224,7 @@ END
 
 IDD_BUTTONS_OPTIONS DIALOGEX 0, 0, 338, 365
 STYLE DS_SETFONT | DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU
-CAPTION "Options - Buttons"
+CAPTION "Options – Buttons"
 FONT 8, "Segoe UI", 400, 0, 0x0
 BEGIN
     LTEXT           "Buttons",IDC_BUTTONS_H1,14,7,310,13
@@ -306,7 +306,7 @@ END
 
 IDD_QUICK_SETUP DIALOGEX 0, 0, 268, 234
 STYLE DS_SETFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
-CAPTION "Quick Setup - Columns UI"
+CAPTION "Quick setup – Columns UI"
 FONT 8, "Segoe UI", 400, 0, 0x0
 BEGIN
     LTEXT           "Layout",IDC_STATIC,14,7,60,8
@@ -356,7 +356,6 @@ END
 
 IDD_EDIT_GROUP DIALOGEX 0, 0, 320, 157
 STYLE DS_SETFONT | DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU
-CAPTION "Add New Group"
 FONT 8, "Segoe UI", 400, 0, 0x0
 BEGIN
     EDITTEXT        IDC_VALUE,7,18,306,68,ES_MULTILINE | ES_AUTOVSCROLL | ES_WANTRETURN | WS_VSCROLL
@@ -520,7 +519,7 @@ END
 
 IDD_ITEM_PROPS_OPTIONS DIALOGEX 0, 0, 268, 385
 STYLE DS_SETFONT | DS_MODALFRAME | DS_FIXEDSYS | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
-CAPTION "Options - Item Properties"
+CAPTION "Options – Item properties"
 FONT 8, "MS Shell Dlg", 400, 0, 0x1
 BEGIN
     LTEXT           "Fields",IDC_STATIC,14,7,25,8
@@ -540,7 +539,7 @@ END
 
 IDD_ITEM_DETAILS_OPTIONS DIALOGEX 0, 0, 284, 350
 STYLE DS_SETFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
-CAPTION "Options - Item Details"
+CAPTION "Options – Item details"
 FONT 8, "Segoe UI", 400, 0, 0x0
 BEGIN
     LTEXT           "Title format",IDC_STATIC,14,7,40,8

diff --git a/foo_ui_columns/ng_playlist/ng_playlist_prefs_groups.cpp b/foo_ui_columns/ng_playlist/ng_playlist_prefs_groups.cpp
@@ -15,7 +15,7 @@ static INT_PTR CALLBACK EditViewProc(edit_view_param& state, HWND wnd, UINT msg,
 {
     switch (msg) {
     case WM_INITDIALOG: {
-        SetWindowText(wnd, state.b_new ? L"Add New Group" : L"Edit Group");
+        SetWindowText(wnd, state.b_new ? L"Add new group" : L"Edit group");
 
         uSendDlgItemMessageText(wnd, IDC_PLAYLIST_FILTER_TYPE, CB_ADDSTRING, 0, "Show on all playlists");
         uSendDlgItemMessageText(wnd, IDC_PLAYLIST_FILTER_TYPE, CB_ADDSTRING, 0, "Show only on playlists:");