Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtins): skip unenumerable vars in set builtin #322

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Jan 13, 2025

No description provided.

@reubeno reubeno enabled auto-merge (squash) January 13, 2025 08:13
@reubeno reubeno merged commit e2aec7b into main Jan 13, 2025
17 checks passed
@reubeno reubeno deleted the hidden-from-set branch January 13, 2025 08:23
Copy link

Test Results

    2 files      9 suites   1m 18s ⏱️
  585 tests   585 ✅ 0 💤 0 ❌
1 156 runs  1 156 ✅ 0 💤 0 ❌

Results for commit 2b029e5.

Copy link

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 16.50 μs 16.39 μs -0.11 μs ⚪ Unchanged
eval_arithmetic 0.19 μs 0.19 μs -0.00 μs ⚪ Unchanged
expand_one_string 1.63 μs 1.65 μs 0.02 μs ⚪ Unchanged
for_loop 33.28 μs 32.67 μs -0.61 μs ⚪ Unchanged
function_call 3.72 μs 3.39 μs -0.33 μs 🟢 -8.84%
instantiate_shell 47.81 μs 48.27 μs 0.46 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 24647.77 μs 24270.80 μs -376.97 μs ⚪ Unchanged
parse_bash_completion 1700.81 μs 1677.38 μs -23.44 μs 🟢 -1.38%
parse_sample_script 2.21 μs 2.15 μs -0.07 μs 🟢 -3.03%
run_echo_builtin_command 16.75 μs 16.09 μs -0.66 μs ⚪ Unchanged
run_one_external_command 1976.61 μs 1724.38 μs -252.23 μs 🟢 -12.76%

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/builtins/set.rs 🟠 60.69% 🟠 59.66% 🔴 -1.03%
brush-core/src/jobs.rs 🔴 37.07% 🔴 43.1% 🟢 6.03%
brush-core/src/shell.rs 🟢 82.27% 🟢 82.4% 🟢 0.13%
Overall Coverage 🟢 76.96% 🟢 77.04% 🟢 0.08%

Minimum allowed coverage is 70%, this run produced 77.04%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant