-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: reimplement colon command as a "simple builtin" #315
Conversation
Test Results 2 files 9 suites 1m 22s ⏱️ Results for commit 95acf24. ♻️ This comment has been updated with latest results. |
Performance Benchmark Report
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
} | ||
builtins::ContentType::ShortUsage => Ok(":: :".into()), | ||
builtins::ContentType::ShortDescription => Ok(": - Null command".into()), | ||
builtins::ContentType::ManPage => error::unimp("man page not yet implemented"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message 'man page not yet implemented' is unclear. It should be updated to 'Man page rendering is not yet implemented for this command.'
builtins::ContentType::ManPage => error::unimp("man page not yet implemented"), | |
builtins::ContentType::ManPage => error::unimp("Man page rendering is not yet implemented for this command."), |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
No description provided.