Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle expansion in here documents #212

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: handle expansion in here documents #212

merged 1 commit into from
Oct 17, 2024

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Oct 17, 2024

No description provided.

@reubeno reubeno force-pushed the here-doc-expansion branch from 953f797 to 977890f Compare October 17, 2024 05:29
Copy link

github-actions bot commented Oct 17, 2024

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.42 μs 3.42 μs -0.00 μs ⚪ Unchanged
instantiate_shell 59.88 μs 60.72 μs 0.84 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 28124.08 μs 27846.01 μs -278.08 μs 🟢 -0.99%
parse_bash_completion 2649.46 μs 2738.85 μs 89.39 μs 🟠 +3.37%
parse_sample_script 3.83 μs 4.02 μs 0.19 μs 🟠 +4.91%
run_echo_builtin_command 90.58 μs 91.19 μs 0.61 μs ⚪ Unchanged
run_one_builtin_command 109.95 μs 108.94 μs -1.02 μs ⚪ Unchanged
run_one_external_command 1981.14 μs 1912.48 μs -68.66 μs 🟢 -3.47%
run_one_external_command_directly 1013.79 μs 1010.08 μs -3.71 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-parser/src/tokenizer.rs 🟢 96.27% 🟢 96.48% 🟢 0.21%
Overall Coverage 🟢 75.48% 🟢 75.56% 🟢 0.08%

Minimum allowed coverage is 70%, this run produced 75.56%

@reubeno reubeno enabled auto-merge (squash) October 17, 2024 05:36
@reubeno reubeno merged commit 6b97024 into main Oct 17, 2024
11 checks passed
@reubeno reubeno deleted the here-doc-expansion branch October 17, 2024 05:37
39555 pushed a commit to 39555/brush that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant