chore: update comments (#129)

reubeno · Jul 18, 2024 · 18e7a30 · 18e7a30
1 parent 646fdff
commit 18e7a30
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/brush-core/src/sys/stubs/fs.rs b/brush-core/src/sys/stubs/fs.rs
@@ -1,17 +1,14 @@
 #[cfg(not(unix))]
 impl crate::sys::fs::PathExt for std::path::Path {
     fn readable(&self) -> bool {
-        // TODO: implement
         true
     }
 
     fn writable(&self) -> bool {
-        // TODO: implement
         true
     }
 
     fn executable(&self) -> bool {
-        // TODO: implement
         true
     }
 
@@ -46,12 +43,10 @@ impl crate::sys::fs::PathExt for std::path::Path {
 
 pub(crate) trait StubMetadataExt {
     fn gid(&self) -> u32 {
-        // TODO: implement
         0
     }
 
     fn uid(&self) -> u32 {
-        // TODO: implement
         0
     }
 }

diff --git a/brush-parser/src/arithmetic.rs b/brush-parser/src/arithmetic.rs
@@ -101,7 +101,7 @@ peg::parser! {
         rule _() -> () = quiet!{[' ' | '\t' | '\n' | '\r']*} {}
 
         rule literal_number() -> i64 =
-            // TODO: handle binary?
+            // TODO: handle explicit radix (e.g., <base>#<literal>) for bases 2 through 64
             "0" ['x' | 'X'] s:$(['0'..='9' | 'a'..='f' | 'A'..='F']*) {? i64::from_str_radix(s, 16).or(Err("i64")) } /
             s:$("0" ['0'..='8']*) {? i64::from_str_radix(s, 8).or(Err("i64")) } /
             s:$(['1'..='9'] ['0'..='9']*) {? s.parse().or(Err("i64")) }