Merge pull request #427 from reubenmiller/fix-remoteaccess-ssh

fix: remoteaccess connect ssh handling of empty port-forwarding options
reubenmiller · Jan 29, 2025 · 9ec2335 · 9ec2335
2 parents ffce564 + 3a94eb7
commit 9ec2335
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/Taskfile.yml b/Taskfile.yml
@@ -193,7 +193,7 @@ tasks:
       - goreleaser build --clean --snapshot --single-target --id {{.OS_NAME}} {{.CLI_ARGS}}
       - rm -f .bin/c8y
       - mkdir -p .bin
-      - cp dist/{{.OS_NAME}}_{{OS}}_{{.ARCH_NAME}}/bin/c8y .bin/c8y
+      - cp dist/{{.OS_NAME}}_{{OS}}_{{.ARCH_NAME}}*/bin/c8y .bin/c8y
 
   generate:
     desc: Generate the cli code

diff --git a/pkg/cmd/remoteaccess/connect/ssh/ssh.manual.go b/pkg/cmd/remoteaccess/connect/ssh/ssh.manual.go
@@ -107,6 +107,11 @@ func NewCmdSSH(f *cmdutil.Factory) *CmdSSH {
 func (n *CmdSSH) GetPortForwarding() string {
 	// convenience functions to mirror docker port mapping options
 	portMapping := n.portForwarding
+
+	if portMapping == "" {
+		return portMapping
+	}
+
 	portForwardingParts := strings.Split(portMapping, ":")
 	switch len(portForwardingParts) {
 	case 1: