Replace godot-videodecoder
with EIRTeam.FFmpeg
#376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #361.
This replaces the internal FFMPEG backend from the old and buggy
godot-videodecoder
toEIRTeam.FFmpeg
, which is being maintained and will hopefully be less painful to work with.This works as a drop-in replacement, so no changes are required on the project. However, fetching the video length required a hack on the old backend, and the new one has the proper function call implemented. As such, themes will need to change to the new system.
Additionaly, the FFmpeg build from this new change uses openh264 instead of libx264. This no longer enforces a GPL3.0 license, but rather the LGPL3.0 one, which allows linking to the compiled library without enforcing its license. Thus, this allows for the app to be fully MIT, and no longer require the special GPL3.0 handling for compiled binaries, so all references for that scenario have been erased.
The CI actions were also refactored to be more modular. This reduces iteration times by ensuring time-consuming dependencies get cached even when the build process fails, and allows for some parallelism as well.