Clean cli internal structures #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atenart
requested changes
Mar 3, 2025
Merge both structs in one keeping the double parsing because of logging. Signed-off-by: Adrian Moreno <[email protected]>
vlrpl
reviewed
Mar 12, 2025
vlrpl
reviewed
Mar 12, 2025
Early initializing of the inspector based on kconf option is only used in "collect" and "inspect". Move the option there (no need to keep it global), and remove the ugly hack in main.rs. In order to keep `retis_in_container.sh` working, remove the use of RETIS_KCONF and instead map all well known config paths and suggest users to use the `--kconf` option as failback. Signed-off-by: Adrian Moreno <[email protected]>
Move the fixup to in between cli parsing rounds. This is when we know the loggig level and we know if we have to redirect logging to stdout when pager is configured. Signed-off-by: Adrian Moreno <[email protected]>
Signed-off-by: Adrian Moreno <[email protected]>
atenart
approved these changes
Mar 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the natural follow up of #464 , and as discussed in #493 (comment)
This PR merges the two-struct model into a single
RetisClistruct and moves some top-level options down the relevant sub-commands.