Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Bump btf-rs to 1.2 #497

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[RFC] Bump btf-rs to 1.2 #497

wants to merge 4 commits into from

Conversation

atenart
Copy link
Contributor

@atenart atenart commented Feb 27, 2025

RFC as btf-rs 1.2 is not released yet. This make Retis use the btf-rs BtfCollection.

@atenart atenart added this to the v1.6 milestone Feb 27, 2025
@vlrpl
Copy link
Contributor

vlrpl commented Feb 28, 2025

I quickly went through this.
As a general comment, I'm in favor of this as it will be logically useful to decouple things in the outstanding effort in #496.
But other than that, things look more natural this way.
After a quick glance, I didn't spot anything worthy of comments code-wise, but I'll reserve the right to take a second look :) if/when we decide to move this forward.

Edit:

I didn't spot anything worthy of comments code-wise

of course, other than the infamous version bump in Cargo.lock, but we all know it is trying to sneak into the code and break c8s :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants