Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] btf/meta filter: introduce boolean expressions #496

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

doc: update filtering.md

2cee873
Select commit
Loading
Failed to load commit list.
Open

[RFC] btf/meta filter: introduce boolean expressions #496

doc: update filtering.md
2cee873
Select commit
Loading
Failed to load commit list.
Cirrus CI / unittest failed Feb 24, 2025 in 5m 48s

Task Summary

Instruction check failed in 00:58

Details

⚠️ Not enough compute credits to prioritize tasks!

✅ 00:03 clone
✅ 00:05 registry
✅ 00:15 target
✅ 00:26 setup
✅ 00:01 before_cache
✅ 02:42 build
✅ 01:13 test
❌ 00:58 check

    |                ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `tcp.flags & (1 << 4)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence

error: operator precedence can trip the unwary
  --> retis-events/src/skb_tracking.rs:35:9
   |
35 |         (self.timestamp as u128) << 64 | self.orig_head as u128
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((self.timestamp as u128) << 64) | self.orig_head as u128`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence

    Checking pnet_packet v0.34.0
    Checking signal-hook v0.3.17
    Checking flate2 v1.0.35
    Checking pcap-file v2.0.0
    Checking clap_complete v4.5.38
    Checking syn v2.0.90
error: useless conversion to the same type: `pyo3::PyErr`
   --> retis-events/src/python.rs:115:55
    |
115 |     pub fn sections(&self, py: Python<'_>) -> PyResult<Py<PyList>> {
    |                                                       ^ help: consider removing
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

error: useless conversion to the same type: `pyo3::PyErr`
   --> retis-events/src/python.rs:353:44
    |
353 |     pub(crate) fn sorted(&self) -> PyResult<bool> {
    |                                            ^ help: consider removing
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `pyo3::PyErr`
   --> retis-events/src/python.rs:360:44
    |
360 |     pub(crate) fn events(&self) -> PyResult<PyEventReader> {
    |                                            ^ help: consider removing
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `pyo3::PyErr`
   --> retis-events/src/python.rs:364:44
    |
364 |     pub(crate) fn series(&self) -> PyResult<PySeriesReader> {
    |                                            ^ help: consider removing
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: could not compile `retis-events` (lib) due to 16 previous errors
warning: build failed, waiting for other jobs to finish...

Exit status: 101