Update unsigned_long API specification tests baseline to 2.8.0 (opens…

…earch-project#7481) (opensearch-project#7487) (cherry picked from commit 0d3c61d) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta · May 10, 2023 · ec271f7 · ec271f7
1 parent 47a3d8a
commit ec271f7
Show file tree

Hide file tree

Showing 22 changed files with 369 additions and 54 deletions.
diff --git a/libs/common/src/main/java/org/opensearch/common/Numbers.java b/libs/common/src/main/java/org/opensearch/common/Numbers.java
@@ -172,6 +172,9 @@ public static BigInteger toUnsignedLongExact(Number value) {
     private static BigDecimal BIGDECIMAL_GREATER_THAN_LONG_MAX_VALUE = BigDecimal.valueOf(Long.MAX_VALUE).add(BigDecimal.ONE);
     private static BigDecimal BIGDECIMAL_LESS_THAN_LONG_MIN_VALUE = BigDecimal.valueOf(Long.MIN_VALUE).subtract(BigDecimal.ONE);
     private static BigDecimal BIGDECIMAL_GREATER_THAN_USIGNED_LONG_MAX_VALUE = new BigDecimal(MAX_UNSIGNED_LONG_VALUE).add(BigDecimal.ONE);
+    private static BigDecimal BIGDECIMAL_LESS_THAN_USIGNED_LONG_MIN_VALUE = new BigDecimal(MIN_UNSIGNED_LONG_VALUE).subtract(
+        BigDecimal.ONE
+    );
 
     /** Return the long that {@code stringValue} stores or throws an exception if the
      *  stored value cannot be converted to a long that stores the exact same
@@ -212,7 +215,7 @@ public static BigInteger toUnsignedLong(String stringValue, boolean coerce) {
         try {
             BigDecimal bigDecimalValue = new BigDecimal(stringValue);
             if (bigDecimalValue.compareTo(BIGDECIMAL_GREATER_THAN_USIGNED_LONG_MAX_VALUE) >= 0
-                || bigDecimalValue.compareTo(BigDecimal.ZERO) <= 0) {
+                || bigDecimalValue.compareTo(BIGDECIMAL_LESS_THAN_USIGNED_LONG_MIN_VALUE) <= 0) {
                 throw new IllegalArgumentException("Value [" + stringValue + "] is out of range for an unsigned long");
             }
             bigIntegerValue = coerce ? bigDecimalValue.toBigInteger() : bigDecimalValue.toBigIntegerExact();

diff --git a/rest-api-spec/src/main/resources/rest-api-spec/test/index/90_unsigned_long.yml b/rest-api-spec/src/main/resources/rest-api-spec/test/index/90_unsigned_long.yml
@@ -1,7 +1,7 @@
 setup:
   - skip:
-      version: " - 2.99.99"
-      reason: unsigned_long is not supported before 3.0.0
+      version: " - 2.7.99"
+      reason: unsigned_long is not supported before 2.8.0
 
   - do:
       indices.create:

diff --git a/...spec/src/main/resources/rest-api-spec/test/search.aggregation/100_avg_metric_unsigned.yml b/...spec/src/main/resources/rest-api-spec/test/search.aggregation/100_avg_metric_unsigned.yml
@@ -1,7 +1,7 @@
 setup:
   - skip:
-      version: " - 2.99.99"
-      reason: unsigned_long is not supported before 3.0.0
+      version: " - 2.7.99"
+      reason: unsigned_long is not supported before 2.8.0
 
   - do:
       indices.create:

diff --git a/...spec/src/main/resources/rest-api-spec/test/search.aggregation/110_max_metric_unsigned.yml b/...spec/src/main/resources/rest-api-spec/test/search.aggregation/110_max_metric_unsigned.yml
@@ -1,7 +1,7 @@
 setup:
   - skip:
-      version: " - 2.99.99"
-      reason: unsigned_long is not supported before 3.0.0
+      version: " - 2.7.99"
+      reason: unsigned_long is not supported before 2.8.0
 
   - do:
       indices.create:

diff --git a/...spec/src/main/resources/rest-api-spec/test/search.aggregation/120_min_metric_unsigned.yml b/...spec/src/main/resources/rest-api-spec/test/search.aggregation/120_min_metric_unsigned.yml
@@ -1,7 +1,7 @@
 setup:
   - skip:
-      version: " - 2.99.99"
-      reason: unsigned_long is not supported before 3.0.0
+      version: " - 2.7.99"
+      reason: unsigned_long is not supported before 2.8.0
 
   - do:
       indices.create:

diff --git a/...spec/src/main/resources/rest-api-spec/test/search.aggregation/130_sum_metric_unsigned.yml b/...spec/src/main/resources/rest-api-spec/test/search.aggregation/130_sum_metric_unsigned.yml
@@ -1,7 +1,7 @@
 setup:
   - skip:
-      version: " - 2.99.99"
-      reason: unsigned_long is not supported before 3.0.0
+      version: " - 2.7.99"
+      reason: unsigned_long is not supported before 2.8.0
 
   - do:
       indices.create:

diff --git a/.../main/resources/rest-api-spec/test/search.aggregation/140_value_count_metric_unsigned.yml b/.../main/resources/rest-api-spec/test/search.aggregation/140_value_count_metric_unsigned.yml
@@ -1,7 +1,7 @@
 setup:
   - skip:
-      version: " - 2.99.99"
-      reason: unsigned_long is not supported before 3.0.0
+      version: " - 2.7.99"
+      reason: unsigned_long is not supported before 2.8.0
 
   - do:
       indices.create:

diff --git a/...ec/src/main/resources/rest-api-spec/test/search.aggregation/150_stats_metric_unsigned.yml b/...ec/src/main/resources/rest-api-spec/test/search.aggregation/150_stats_metric_unsigned.yml
@@ -1,7 +1,7 @@
 setup:
   - skip:
-      version: " - 2.99.99"
-      reason: unsigned_long is not supported before 3.0.0
+      version: " - 2.7.99"
+      reason: unsigned_long is not supported before 2.8.0
 
   - do:
       indices.create:

diff --git a/...in/resources/rest-api-spec/test/search.aggregation/160_extended_stats_metric_unsigned.yml b/...in/resources/rest-api-spec/test/search.aggregation/160_extended_stats_metric_unsigned.yml
@@ -1,7 +1,7 @@
 setup:
   - skip:
-      version: " - 2.99.99"
-      reason: unsigned_long is not supported before 3.0.0
+      version: " - 2.7.99"
+      reason: unsigned_long is not supported before 2.8.0
 
   - do:
       indices.create:

diff --git a/.../main/resources/rest-api-spec/test/search.aggregation/170_cardinality_metric_unsigned.yml b/.../main/resources/rest-api-spec/test/search.aggregation/170_cardinality_metric_unsigned.yml
@@ -1,7 +1,7 @@
 setup:
   - skip:
-      version: " - 2.99.99"
-      reason: unsigned_long is not supported before 3.0.0
+      version: " - 2.7.99"
+      reason: unsigned_long is not supported before 2.8.0
 
   - do:
       indices.create: