This repository has been archived by the owner on Feb 14, 2025. It is now read-only.
Introduce service.Version and discovery.Version enums #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
issues/92
branch
4 times, most recently
from
755b5c0 to
8e85179
Compare
dev/restate/service/discovery.proto
Outdated
Comment on lines
18
to
22
| enum Version { | ||
| VERSION_UNSPECIFIED = 0; | ||
| // initial service discovery protocol version using endpoint_manifest_schema.json | ||
| V1 = 1; | ||
| } |
There was a problem hiding this comment.
How about moving this and the other enum in an ad-hoc proto file, like version.proto?
There was a problem hiding this comment.
One reason this Version is in a different file than the protocol version is because otherwise the V1 variants of both enums would clash. That's why they need to be placed in different packages.
tillrohrmann
force-pushed
the
issues/92
branch
2 times, most recently
from
53a7348 to
2e6fd5a
Compare
slinkydeveloper
approved these changes
May 14, 2024
This commit introduces the service.Version and discovery.Version enums which define the protocol versions of the service and the service discovery protocol. This fixes restatedev#92.
|
Thanks for the review @slinkydeveloper. Merging this PR now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the service.Version and discovery.Version
enums which define the protocol versions of the service and the
service discovery protocol.
This fixes #92.
This PR is based on #90.