Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delay #41

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix delay #41

merged 1 commit into from
Feb 18, 2025

Conversation

slinkydeveloper
Copy link
Collaborator

No description provided.

Copy link

Test Results

  7 files  ±0    7 suites  ±0   3m 35s ⏱️ ±0s
 45 tests ±0   44 ✅ ±0  1 💤 ±0  0 ❌ ±0 
174 runs  ±0  171 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit e9ec9fe. ± Comparison against base commit 1111a47.

Copy link

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this problem so quickly @slinkydeveloper. +1 for merging and creating a new release.

@tillrohrmann
Copy link

Can we also add a test for it?

@slinkydeveloper
Copy link
Collaborator Author

@tillrohrmann will add a test in the integration test suite restatedev/sdk-test-suite#34

@slinkydeveloper slinkydeveloper merged commit 75ac266 into main Feb 18, 2025
4 checks passed
@slinkydeveloper slinkydeveloper deleted the fix-delay branch February 18, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants