Skip to content

Commit

Permalink
Add invocation status killed test to CI
Browse files Browse the repository at this point in the history
  • Loading branch information
slinkydeveloper committed Nov 21, 2024
1 parent d57419d commit 59628f2
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 5 deletions.
18 changes: 18 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,24 @@ jobs:
RUST_LOG=info,restate_invoker=trace,restate_ingress_http=trace,restate_bifrost=trace,restate_log_server=trace,restate_core::partitions=trace,restate=debug
testArtifactOutput: sdk-java-kafka-next-gen-integration-test-report

sdk-java-invocation-status-killed:
name: Run SDK-Java integration tests with InvocationStatusKilled
permissions:
contents: read
issues: read
checks: write
pull-requests: write
actions: read
secrets: inherit
needs: docker
uses: restatedev/sdk-java/.github/workflows/integration.yaml@main
with:
restateCommit: ${{ github.event.pull_request.head.sha || github.sha }}
envVars: |
RESTATE_WORKER__EXPERIMENTAL_FEATURE_INVOCATION_STATUS_KILLED=true
RUST_LOG=info,restate_invoker=trace,restate_ingress_http=trace,restate_bifrost=trace,restate_log_server=trace,restate_core::partitions=trace,restate=debug
testArtifactOutput: sdk-java-invocation-status-killed-integration-test-report

sdk-python:
name: Run SDK-Python integration tests
permissions:
Expand Down
8 changes: 4 additions & 4 deletions crates/types/src/config/worker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ pub struct WorkerOptions {
experimental_feature_disable_idempotency_table: bool,

#[cfg_attr(feature = "schemars", schemars(skip))]
experimental_invocation_status_killed: bool,
experimental_feature_invocation_status_killed: bool,

pub storage: StorageOptions,

Expand Down Expand Up @@ -92,8 +92,8 @@ impl WorkerOptions {
self.experimental_feature_disable_idempotency_table
}

pub fn experimental_invocation_status_killed(&self) -> bool {
self.experimental_invocation_status_killed
pub fn experimental_feature_invocation_status_killed(&self) -> bool {
self.experimental_feature_invocation_status_killed
}
}

Expand All @@ -104,7 +104,7 @@ impl Default for WorkerOptions {
num_timers_in_memory_limit: None,
cleanup_interval: Duration::from_secs(60 * 60).into(),
experimental_feature_disable_idempotency_table: false,
experimental_invocation_status_killed: false,
experimental_feature_invocation_status_killed: false,
storage: StorageOptions::default(),
invoker: Default::default(),
max_command_batch_size: NonZeroUsize::new(4).expect("Non zero number"),
Expand Down
2 changes: 1 addition & 1 deletion crates/worker/src/partition/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ where
status,
num_timers_in_memory_limit: options.num_timers_in_memory_limit(),
disable_idempotency_table: options.experimental_feature_disable_idempotency_table(),
invocation_status_killed: options.experimental_invocation_status_killed(),
invocation_status_killed: options.experimental_feature_invocation_status_killed(),
cleanup_interval: options.cleanup_interval(),
channel_size: options.internal_queue_length(),
max_command_batch_size: options.max_command_batch_size(),
Expand Down

0 comments on commit 59628f2

Please sign in to comment.