fix: block next 15 update #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prescottprue
requested review from
hershmire and
alexsupp
and removed request for
a team
hershmire
requested changes
Nov 5, 2024
| @@ -12,6 +12,11 @@ | |||
| "matchUpdateTypes": ["patch", "minor"], | |||
| "groupName": "MUI X", | |||
| "updateNotScheduled": false | |||
| }, | |||
There was a problem hiding this comment.
Considering not all UIs are using Recoil, can this go within those UIs specifically vs making this global?
There was a problem hiding this comment.
Every UI other than identity is using recoil - my thinking was to skip across all then have an override in each repo that makes the change instead of needing to skip in every UI other than identity.
I'm fine doing the skip in each repo though
There was a problem hiding this comment.
Looks like just identity-ui is not using Recoil :(. That's really a shame that we went all in on this lib.
There was a problem hiding this comment.
Let's skip in the UIs vs global.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ TICKET-000
Upstream PRs
Downstream PRs
Changes
As called out here Recoil doesn't support react 19 (and won't) which blocks updating any UIs using recoil to Next 15: https://residenetwork.atlassian.net/browse/PLAT-8597 (all UIs other than identity)
Jotai is a great replacement that we were already talking about making the switch to anyway (since FB team said they won't be up keeping Recoil anymore) - the change looks close to a drop in replacement but it will require testing of everything using Recoil (edited)
Notes for Reviewers
For identity-ui (and each UI that makes the update) we will add a repo level renovate override to allow next versions >15
Recordings/Screenshots