Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-86: Fixed crash bug on load error on disposed resources. #87

Merged
merged 1 commit into from
May 2, 2019
Merged

GH-86: Fixed crash bug on load error on disposed resources. #87

merged 1 commit into from
May 2, 2019

Conversation

jirenius
Copy link
Collaborator

@jirenius jirenius commented May 2, 2019

Also added cyclic HTTP get tests.

@jirenius jirenius merged commit 882c623 into develop May 2, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 97

  • 14 of 16 (87.5%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 82.001%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/subscription.go 14 16 87.5%
Files with Coverage Reduction New Missed Lines %
server/subscription.go 1 82.21%
Totals Coverage Status
Change from base Build 95: -0.09%
Covered Lines: 2287
Relevant Lines: 2789
💛 - Coveralls

@jirenius jirenius deleted the bugfix/gh-86-crash-on-timed-out-resources branch May 2, 2019 11:57
@jirenius jirenius mentioned this pull request May 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirenius @coveralls