Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete event #83

Closed
jirenius opened this issue May 2, 2019 · 1 comment
Closed

Delete event #83

jirenius opened this issue May 2, 2019 · 1 comment
Assignees
@jirenius
Labels
enhancement New feature or request

Comments

@jirenius
Copy link
Collaborator

jirenius commented May 2, 2019 •
edited
Loading

Story

The services need a way to tell Resgate that a resource has been deleted, and that it should no longer be served from the cache.

Solution

Expand the RES protocol to include support for a delete event. Since the protocol already states that delete is a reserved event name, this change will not break backwards compatibility.

Any subsequent client request for the resource should be handled the same way as for any other resource.

Notes

  • delete events are valid for all resource types
  • when Resgate receives a delete event, it should delete the resource from the cache.
  • if the resource is not a query resource, or if there are no more query subscriptions, the resource should eventually be unsubscribe to NATS.
  • the event should be propagated further on to the client.
  • the client should not do anything. The resource will remain in the client's cache until unsubscribed.
@jirenius jirenius added the enhancement New feature or request label May 2, 2019
jirenius added a commit that referenced this issue Oct 28, 2019
@jirenius
GH-83: Added RES Protocol CHANGELOG.md.
00fc90c
jirenius added a commit that referenced this issue Oct 28, 2019
@jirenius
GH-83: Added delete and create event to RES protocol.
ce74a4b 
Added support for delete event to resgate.
Added tests for delete event.
jirenius added a commit that referenced this issue Oct 28, 2019
@jirenius
GH-83: Generate delete event event on system.reset with notFound resp…
7932b7e 
…onse.
jirenius added a commit that referenced this issue Oct 28, 2019
@jirenius
GH-83: Generate delete event on query response with system.notFound e…
702727e 
…rror.

Added delete tests for query events.
jirenius added a commit that referenced this issue Oct 28, 2019
@jirenius
GH-83: Fixed misspelling
aa87d5c
jirenius added a commit that referenced this issue Oct 29, 2019
@jirenius
Merge pull request #133 from resgateio/feature/gh-83-delete-event
0480426 
Feature/gh 83 delete event
@jirenius jirenius self-assigned this Oct 29, 2019
@jirenius
Copy link
Collaborator Author

Resolved in #133

jirenius added a commit that referenced this issue Nov 15, 2019
@jirenius
GH-83: Simplified code line.
6fbe758
@jirenius jirenius mentioned this issue Dec 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jirenius jirenius

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jirenius