Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow consumer error not handled #220

Closed
jirenius opened this issue Nov 12, 2021 · 1 comment
Closed

Slow consumer error not handled #220

jirenius opened this issue Nov 12, 2021 · 1 comment
Assignees
@jirenius
Labels
bug Something isn't working

Comments

@jirenius
Copy link
Collaborator

jirenius commented Nov 12, 2021 •
edited
Loading

Issue

Under heavy bursts of incoming messages from NATS, Resgate may silently drop events. The slow consumer error from nats client is not handled.

Solution

Make the message buffer channel size configurable, and increase default from 256 to 8192.
On slow consumer error, Resgate should shut down with a clear error, allowing for restart.
@jirenius jirenius added the bug Something isn't working label Nov 12, 2021
@jirenius jirenius self-assigned this Nov 12, 2021
jirenius added a commit that referenced this issue Nov 12, 2021
@jirenius
GH-220: Added channel buffer size as config property.
697cf6e 
Increased default buffer size from 256 to 8192.
Closing server on nats.ErrSlowConsumer error.
jirenius added a commit that referenced this issue Nov 12, 2021
@jirenius
Merge pull request #221 from resgateio/bugfix/gh-220-slow-consumer-er…
8091bd1 
…ror-not-handled

Bugfix/gh 220 slow consumer error not handled
@jirenius
Copy link
Collaborator Author

Resolved in PR #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jirenius jirenius

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jirenius