Run Linux & Windows screenshot tests via lavapipe software rasterizer
#8620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🔨 testing
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
Wumpf
changed the title
llvmpipe software rasterizerlavapipe software rasterizer
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12694704438 |
Wumpf
force-pushed
the
andreas/enable-screenshottests-always
branch
from
26f6c59 to
ac927bd
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12695361164 |
Wumpf
force-pushed
the
andreas/enable-screenshottests-always
branch
from
ac927bd to
25206ca
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12696447614 |
emilk
approved these changes
Jan 10, 2025
Comment on lines
+104
to
+105
| # TODO(andreas): It would be nice if `setup_software_rasterizer.py` could do that for us as well (note though that this action here is very fast when cached!) | ||
| - name: Install Vulkan SDK |
There was a problem hiding this comment.
Once this PR is merged, we should test this path with a new "external" PR
Wumpf
force-pushed
the
andreas/enable-screenshottests-always
branch
from
07c3ba5 to
f8f844f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Enables screenshot tests on Linux & Windows ci using Mesa lavapipe (the Vulkan version of llvmpipe) software rasterizer.
Uses wgpu's Mesa build https://github.com/gfx-rs/ci-build (thanks @cwfitzgerald!)
ICD driver file discovery & how to best download the Vulkan SDK was giving me a bit of a headache (via apt as done on wgpu's ci was very slow for some reason and wgpu only does GL software rasterizing on Windows). But it's all figured out now & documented in the setup script :). The process can be replicated locally the same way, but has a bit of "you better know what you're doing" to it as the driver setup is a little bit invasive to account for elevated user access ([...] see comments).
Changes to our CI pipelines overall:
--all-targets --all-featuresinstead of both that and with just--all-targetscargo test --all-targets --all-featuresnot only on Mac but also on Windowspixi run rs-checknot only on Linux but also on Windows & Mac