Show preview of Image/DepthImage/SegmentationImage when selected
#7147
Conversation
emilk
added
ui
|
Small images need nearest neighbor filtering (well, in generally that's probably what we should do for MAG here :)) |
| Ok(response) => response.on_hover_ui(|ui| { | ||
| // Show larger image on hover. | ||
| let hover_size = Vec2::splat(400.0); | ||
| show_image_preview(render_ctx, ui, texture, &debug_name, hover_size).ok(); | ||
| }), |
There was a problem hiding this comment.
Where would this path be active? Wasn't able to get there in the ui.
There was a problem hiding this comment.
I don't think we ever show an Entity in a list-view right now, but we do show ImageEncoded in a list view:
| indicator_count == components.len() | ||
| if instance.is_all() { | ||
| let component_map = components.into_iter().collect(); | ||
| preview_if_image_ui(ctx, ui, ui_layout, query, entity_path, &component_map); |
There was a problem hiding this comment.
I wish there was a more scalable way for "pan entity ui" already. But this simple special handling will probably go a long way 🤷
| @@ -59,106 +70,222 @@ impl DataUi for InstancePath { | |||
| if indicator_count > 1 { "s" } else { "" } | |||
| ), | |||
| ); | |||
There was a problem hiding this comment.
since the return; got removed here we're still evaluating the image preview if this is a single line. I don't know what this could break in the ui (haven't spotted anything) but this might be wrong? (could be that something down the line opts out, but I'm not seeing it in this diff at least)
There was a problem hiding this comment.
The idea is that if we put an Entity in a list view, we should see a small preview image, like we currently do for ImageEncoded blobs:
There was a problem hiding this comment.
I prefer this way of writing it to early returns anyway
| }); | ||
| } | ||
|
|
||
| /// If this entity is an image, show it together with buttons to download and copy the image. |
There was a problem hiding this comment.
those download buttons aren't there yet
There was a problem hiding this comment.
Give me a couple of hours :)
What
When you select an entity that contains an
Image,DepthImageorSegmentationImage, a preview of it will be show.Coming later: button to copy and save/download the image.
Toolip
Selection panel
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.