Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataframe view: add PoV to range query #7279

Closed
abey79 opened this issue Aug 27, 2024 · 2 comments · Fixed by #7380
Closed

Dataframe view: add PoV to range query #7279

abey79 opened this issue Aug 27, 2024 · 2 comments · Fixed by #7380
Assignees
@abey79
Labels
feat-dataframe-view Everything related to the dataframe view ui concerns graphical user interface
Milestone
0.19 - Dataframe ...

Comments

@abey79
Copy link
Member

abey79 commented Aug 27, 2024

In the spirit of matching the dataframe view with the upcoming SDK data-out feature, the range query should be changed to always have one component as PoV.

This actually is a simplifying assumption that (at least partially) unblocks #7066 for range queries.
@abey79 abey79 added the ui concerns graphical user interface label Aug 27, 2024
@abey79 abey79 self-assigned this Aug 27, 2024
@abey79 abey79 changed the title Dataframe: add PoV to range query Dataframe view: add PoV to range query Aug 27, 2024
@abey79
Copy link
Member Author

abey79 commented Aug 29, 2024

Here the design for the UI:

Screen.Recording.2024-08-29.at.12.22.10.mov

@abey79
Copy link
Member Author

abey79 commented Sep 3, 2024

I have a small doubt about the reset button at the level of the "Define time range" radio. It implies that it resets also the pot entity/component, which it doesn't. For now I've put the refresh button at the leave of each of the boundaries.

Also, because it was just easier, I made the +/-inf buttons that must be clicked to turn into the time drag widget. When clicked, the widget is set to the max, resp. min, time of the selected timeline.

new_dataframe_query_ui.mp4

@abey79 abey79 mentioned this issue Sep 3, 2024
Merged
6 tasks
abey79 added a commit that referenced this issue Sep 4, 2024
@abey79
Add point-of-view entity and component to the dataframe view's UI (#7331
fed60d4 
)

### What

- Part of: #7279

This PR updates the dataframe query override UI as per design in #7279,
in particular adding PoV entity and component.
- updated UI layout
- time boundaries default to `+∞`/`–∞` button which, when clicked, turn
into editable time drag value
- reset buttons to go back to the `∞` state
- auto-selection of PoV component based on PoV entity (picks a required
component for one of the entity archetypes)

**Note**:
- This is a pure UI PR. The PoV entity/component are not yet used at all
for the dataframe's content (that will be addressed in a follow-up PR
currently blocked on #7284).
- Ignore the ugly "Time range table order" part, this will be cleaned up
later (#7070)


https://github.com/user-attachments/assets/32151a1f-b0ca-4e99-99df-ea730451d4dc

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7331?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7331?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7331)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@abey79 abey79 added the feat-dataframe-view Everything related to the dataframe view label Sep 9, 2024
@emilk emilk added this to the 0.19 - Dataframe and web video milestone Sep 10, 2024
@abey79 abey79 closed this as completed in e9b02e3 Sep 10, 2024
jprochazk pushed a commit that referenced this issue Sep 11, 2024
@abey79 @emilk
@teh-cmc @jprochazk
Update the dataframe view to use re_dataframe and egui_table (#7380)
8bcbbd9 
### What

- Closes #7279

Major update to the dataframe view
- display the data return by the new `re_dataframe` crate
  - the PoV entity/component is now actually used
  - entities are now always columns
    - see #7379 
- use [`egui_table`](https://github.com/rerun-io/egui_table) for the
table
  - hierarchical header
  - sticky columns
  - and much more...

TODO:
- [x] fix after merging #7383

<img width="2670" alt="image"
src="https://github.com/user-attachments/assets/cf09b69b-3c82-4ba9-9425-bf60622efae4">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7380?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7380?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7380)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: Clement Rey <[email protected]>
@abey79 abey79 mentioned this issue Oct 16, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abey79 abey79

Labels
feat-dataframe-view Everything related to the dataframe view ui concerns graphical user interface
Projects
None yet
Milestone
0.19 - Dataframe and video
Development

Successfully merging a pull request may close this issue.

Update the dataframe view to use re_dataframe and egui_table rerun-io/rerun
2 participants
@emilk @abey79