Skip to content

Commit

Permalink
disable for to_arrow_method as well again
Browse files Browse the repository at this point in the history
  • Loading branch information
Wumpf committed Mar 18, 2024
1 parent 1e2a145 commit f7894e7
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion crates/re_types_builder/src/codegen/cpp/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1501,6 +1501,14 @@ fn to_arrow_method(
return array;
}
};
let return_type = if is_forwarding {
// Disable asan since we got rather strange spurious ci failure on Linux with these methods:
// Some Linux runs end up spamming `AddressSanitizer:DEADLYSIGNAL` indefinitely with no additional information.1
hpp_includes.insert_rerun("compiler_utils.hpp"); // RR_DISABLE_ASAN
quote! { RR_DISABLE_ASAN Result<std::shared_ptr<arrow::Array>> }
} else {
quote! { Result<std::shared_ptr<arrow::Array>> }
};

Method {
docs: format!(
Expand All @@ -1509,7 +1517,7 @@ fn to_arrow_method(
.into(),
declaration: MethodDeclaration {
is_static: true,
return_type: quote! { Result<std::shared_ptr<arrow::Array>> },
return_type,
name_and_parameters: quote! {
to_arrow(const #quoted_namespace::#type_ident* instances, size_t num_instances)
},
Expand Down

0 comments on commit f7894e7

Please sign in to comment.