Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sync tags #25

Merged
merged 3 commits into from
Oct 6, 2020
Merged

feat: sync tags #25

merged 3 commits into from
Oct 6, 2020

Conversation

Gibby
Copy link
Contributor

@Gibby Gibby commented Jul 29, 2020

Added option to support syncing tags also.

@ungless ungless mentioned this pull request Aug 13, 2020
Closed
core23
core23 reviewed Aug 19, 2020
View reviewed changes
zeke
zeke approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@zeke zeke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the conflicts, this change looks good to me. @wei what do you think?

@wei
Copy link
Member

wei commented Oct 5, 2020 •
edited
Loading

Conflicts have been resolved,

@Gibby @core23 @zeke We are already --force pushing branches, should we just force push tags too (SYNC_TAGS is opt-in only, so I don't see too big of a problem)? What do you think?

@wei wei self-assigned this Oct 5, 2020
@wei wei added the enhancement New feature or request label Oct 5, 2020
@zeke
Copy link
Contributor

zeke commented Oct 6, 2020

should we just force push tags too

👍🏼

@wei
Copy link
Member

wei commented Oct 6, 2020 •
edited
Loading

Great! I'll perform some tests and get it into a release! 😄

@wei wei changed the title Add option to also sync tags. feat: sync tags Oct 6, 2020
@wei wei merged commit 35f2d0a into repo-sync:master Oct 6, 2020
@wei
Copy link
Member

wei commented Oct 6, 2020

@all-contributors please add @Gibby for code

@allcontributors allcontributors bot mentioned this pull request Oct 6, 2020
Merged
@allcontributors
Copy link
Contributor

@wei

I've put up a pull request to add @Gibby! 🎉

@wei
Copy link
Member

wei commented Oct 7, 2020

@Gibby @zeke It's been released and accessible via v2.3.0 and v2. Please try it out and lmk if you see any issues 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 left review comments

@zeke zeke zeke approved these changes

Assignees

@wei wei

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gibby @wei @zeke @core23