Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async-aws/ses to composer #418

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Add async-aws/ses to composer #418

merged 1 commit into from
Feb 19, 2021

Conversation

nandogameiro
Copy link
Contributor

Fixes #206 adding async-aws/ses package to composer

This issue was still happening even using the latest version of repman with symfony 5.2

There is a deprecation notice on amazon-mailer package which is triggered when async-aws/ses it's not installed
https://github.com/symfony/amazon-mailer/blob/5.x/Transport/SesTransportFactory.php#L43

Once I manually installed this package on my instance I could get AWS SES working sending emails through ap-southeast-2

Thanks

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #418 (7f8a4a4) into master (2bd1971) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #418   +/-   ##
=========================================
  Coverage     99.38%   99.38%           
  Complexity     1863     1863           
=========================================
  Files           297      297           
  Lines          5871     5871           
=========================================
  Hits           5835     5835           
  Misses           36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bd1971...7f8a4a4. Read the comment docs.

Copy link
Member

@akondas akondas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix 🙏

@akondas akondas merged commit 12681c9 into repman-io:master Feb 19, 2021
@nandogameiro nandogameiro deleted the async-aws branch February 19, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Amazon-Mailer package
2 participants