Introducing cached adapters to reduce IO/HTTP overhead with file handling #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
=========================================
Coverage 99.35% 99.35%
Complexity 1855 1855
=========================================
Files 297 297
Lines 5858 5858
=========================================
Hits 5820 5820
Misses 38 38 Continue to review full report at Codecov.
|
|
@karniv00l please check, if everything is ok then there is a green light on my part 😉 |
karniv00l
approved these changes
Jan 13, 2021
|
Looks good |
akondas
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #359. Small improvement to cache the stats of files being handled inside the application to avoid unnecessary IO or, in worst case, HTTP chatter.