Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to edit packages #299

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Allow user to edit packages #299

merged 4 commits into from
Oct 15, 2020

Conversation

karniv00l
Copy link
Contributor

@karniv00l karniv00l commented Oct 13, 2020 •
edited
Loading

Mentioned in #287

Q: Should we restrict package edit to owners only?

@karniv00l karniv00l requested a review from akondas October 13, 2020 17:27
@codecov
Copy link

codecov bot commented Oct 13, 2020 •
edited
Loading

Codecov Report

Merging #299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #299   +/-   ##
=========================================
  Coverage     99.62%   99.62%           
  Complexity     1943     1943           
=========================================
  Files           291      291           
  Lines          5806     5806           
=========================================
  Hits           5784     5784           
  Misses           22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe2fcf...f097113. Read the comment docs.

@akondas
Copy link
Member

akondas commented Oct 14, 2020

Q: Should we restrict package edit to owners only?

Yes.

akondas
akondas requested changes Oct 14, 2020
View reviewed changes
Copy link
Member

@akondas akondas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restrict edit package action to ROLE_ORGANIZATION_OWNER only 🙏 😉

@akondas
Copy link
Member

akondas commented Oct 15, 2020

LGTM 👍

@karniv00l
Copy link
Contributor Author

Merged with master

Screenshot 2020-10-15 at 13 41 03

@akondas akondas merged commit 1b26aad into repman-io:master Oct 15, 2020
@karniv00l karniv00l deleted the package-edit branch October 23, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akondas akondas akondas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karniv00l @akondas