Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement provider-includes #281

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Conversation

karniv00l
Copy link
Contributor

@karniv00l karniv00l commented Sep 22, 2020

Fixes #261

Test example case:

composer.json

{
    "repositories": [
        {"type": "composer", "url": "https://repo.repman.wip"},
        {"packagist": false}
    ],
    "require": {
        "symfony/symfony": "^5.1"
    }
}
  1. install will fetch packages using providers-lazy-url
composer install --profile --no-plugins -vvv
  1. run sync to create package$hash and provider-latest$hash
symfony console repman:proxy:sync-metadata
  1. update / install will create local cache reading from provider-includes
composer update --profile --no-plugins -vvv
...
[49.7MiB/26.05s] Downloading https://repo.repman.wip/p/symfony/symfony%247991ce39135f0c4c78d637af83ef6e12cde788c209ee3a1576f3addc2f29db47.json
[61.0MiB/26.92s] Writing /Users/piotrek/.composer/cache/repo/https---repo.repman.wip/provider-symfony$symfony.json into cache
...

Subsequent install no vendors (composer install --profile --no-plugins -vvv)

...
Installing doctrine/event-manager (1.1.1): Reading /Users/piotrek/.composer/cache/files/doctrine/event-manager/23170e5878c48f072eeb162c16360f0e139163b4.zip from cache
Loading from cache
...

Subsequent update (composer update --profile --no-plugins -vvv)

...
[7.9MiB/0.11s] Downloading https://repo.repman.wip/packages.json
[7.9MiB/0.93s] Writing /Users/piotrek/.composer/cache/repo/https---repo.repman.wip/packages.json into cache
[8.0MiB/0.93s] Updating dependencies (including require-dev)
[8.1MiB/0.94s] Reading /Users/piotrek/.composer/cache/repo/https---repo.repman.wip/p-provider-latest.json from cache
...
[49.7MiB/1.43s] Reading /Users/piotrek/.composer/cache/repo/https---repo.repman.wip/provider-symfony$symfony.json from cache
...

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #281 into master will decrease coverage by 0.03%.
The diff coverage is 97.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #281      +/-   ##
============================================
- Coverage     99.71%   99.68%   -0.04%     
- Complexity     1793     1818      +25     
============================================
  Files           284      284              
  Lines          5239     5325      +86     
============================================
+ Hits           5224     5308      +84     
- Misses           15       17       +2     
Impacted Files Coverage Δ Complexity Δ
src/Service/Proxy.php 96.24% <96.72%> (+0.03%) 56.00 <24.00> (+22.00)
src/Command/ProxySyncMetadataCommand.php 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
src/Controller/ProxyController.php 100.00% <100.00%> (ø) 12.00 <3.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc87947...299ed89. Read the comment docs.

@karniv00l karniv00l added this to the 1.0.0 milestone Sep 22, 2020
src/Service/Proxy.php Outdated Show resolved Hide resolved
@akondas akondas merged commit 79e1850 into repman-io:master Sep 23, 2020
@karniv00l karniv00l deleted the provider-includes branch September 23, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy considerably slower than Packagist
2 participants