Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use async and stream for downloading metadata and distributions files #226

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Use async and stream for downloading metadata and distributions files #226

merged 1 commit into from
Jul 20, 2020

Conversation

akondas
Copy link
Member

@akondas akondas commented Jul 20, 2020

No description provided.

@akondas akondas requested a review from karniv00l July 20, 2020 10:04
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #226 into static-proxy will decrease coverage by 0.17%.
The diff coverage is 88.52%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             static-proxy     #226      +/-   ##
==================================================
- Coverage           99.87%   99.70%   -0.18%     
- Complexity           1417     1421       +4     
==================================================
  Files                 234      235       +1     
  Lines                4069     4084      +15     
==================================================
+ Hits                 4064     4072       +8     
- Misses                  5       12       +7
Impacted Files Coverage Δ Complexity Δ
src/Service/Dist/Storage/FileStorage.php 100.00% <ø> (ø) 9.00 <0.00> (ø)
src/Service/Downloader/ReactDownloader.php 83.33% <83.33%> (ø) 15.00 <15.00> (?)
src/Command/ProxySyncReleasesCommand.php 100.00% <100.00%> (ø) 13.00 <0.00> (ø)
src/Service/Proxy.php 98.70% <100.00%> (ø) 33.00 <0.00> (-1.00)
src/Service/Proxy/Metadata.php 100.00% <100.00%> (ø) 4.00 <1.00> (-1.00)
src/Service/Stream.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bfbde1...e9175ef. Read the comment docs.

@karniv00l karniv00l merged commit c570e63 into repman-io:static-proxy Jul 20, 2020
@akondas akondas mentioned this pull request Jul 20, 2020
Closed
8 tasks
@akondas akondas deleted the static-proxy branch July 20, 2020 11:21
akondas added a commit that referenced this pull request Jul 21, 2020
@akondas
Use async and stream for downloading metadata and distibutions (#226)
7cbd0bf
karniv00l pushed a commit that referenced this pull request Jul 21, 2020
@akondas
Static proxy with metadata cache (#229)
6c3124f 
* Serve static proxy metadata and use v2 endpoint for dist lookup (#222)

* Move all proxy logic to Proxy class (#223)

* Implement sync proxy metadata command (#224)

* Use async and stream for downloading metadata and distibutions (#226)

* Create migration to better auto upgrade to 0.5.0 (#227)
@karniv00l karniv00l added this to the 0.5.0 milestone Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karniv00l karniv00l karniv00l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@akondas @karniv00l