Fix file too long on tmp file create #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Splits the extension on a ? query parameter * Ensure that the filename in URLPath is truncated
|
lgtm! odd that we don't know exactly how these filenames sneak in there (you'd think they'd all be shortened w/ |
daanelson
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an addendum I don't actually know how this comes to be, in the sense that this was originally created by an input that is a
Pathtype which gets converted to aURLPathand during that conversion the truncation of the filename happens. The truncation is based of parsing the URL and using itspathattribute which should not include queries. However they somehow sneak past this check and show up in the tempfileNamedTemporaryFilemethod. In light of this I've opted to check the length on creation of theURLPathconstruction and provided some tests to verify that.