ACDc Updates #54
Open
ACDc Updates #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the call FS bridges the call to loopback so the test ecallmg_fs_channel:is_bridged() returns true even though it is only bridged to itself. When we then play a message to the Agent it causes ecallmgr_call_command:play() to use "broadcast" rather than "playback". And therefore the CHANNEL_EXECUTE_COMPLETE "FILE PLAYED" event is again blocked and instead only the "BROADCAST SENT" is received but this is received before the file is played and can't be used as a trigger to continue the call setup. This fixes the problem by ignoring bridge to loopback but may not be the right way to fix it. (cherry picked from commit f1c92b4)
(cherry picked from commit 6e2cb1b)
remove spaces (cherry picked from commit 69f1726) remove space fix failing test fix make apis schema upates more schema updates
Visual Studio Code uses the .vscode directory for workspace settings that should not be under source control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.