-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup tokenization #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the search in my Codespaces preview. Search work fine as far as I can tell. I have not seen anything that's obviously broken.
I'll let the maintainers review and eventually merge this. 😉
How can we verify it's working as intended? |
@rarkins expand the thread above, there are screenshots from before merge (there may be some in the issue too), if you get better results, it's working :) Also in general just search for random things you can think of and if you can find it, it works. |
We might live with that if it weren't for the fact that an exact match returns no result! |
Before this change, exact (case sensitively!) returned no result either: #265 (comment) |
Oh, I didn't realize that! Guess I never tried it before, or that I only needed to type part of the word before clicking |
I'll close my PR for now |
Changes:
Context:
I first started by copy/pasting the example regex from the Material for MkDocs manual, and then @TWiStErRob had a better regex for us to try.
Read the Material for MkDocs about
separator
.Helps with issue #264.