feat(presets): Support Bitbucket Cloud local presets #9422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zharinov
commented
Apr 7, 2021
| endpoint, | ||
| fetch: fetchJSONFile, | ||
| }); | ||
| } |
There was a problem hiding this comment.
This code hopefully will be reused by all platforms pretty soon
|
@Chr1stian ;) |
viceice
approved these changes
Apr 7, 2021
|
🎉 This PR is included in version 24.104.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thanks a lot! Will this make JSON5 supported for the preset files as well? |
Nope, only plain JSON |
|
Though, it's on the roadmap #7674 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
My permissions for the configuration repo on BitBucket was wrong. Sorry and please ignore last post! Great work 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Leverage refactored
platform.getRawFile()to support local presets in Bitbucket Cloud platform.Context:
Ref: #9171
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
https://bitbucket.org/zharinov/test-9171-preset-source
https://bitbucket.org/zharinov/test-9171-preset-user
(preset disables Maven, thus no PRs are created)