Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package-rules): matchReleaseAge #30359

Closed
wants to merge 1 commit into from

Conversation

mzglinski
Copy link

Changes

Implement and add matchReleaseAge matcher to the packageRules, equivalent to matchCurrentAge.

Context

For noise impression reasons. My organization requires all PRs not to fall behind a default branch. In a situation where the repository owner ignores the PR for too long, it is updated every time there is a change pushed to the default branch, resulting in constant notifications and unnecessary CI resource consumption. With this rule, we can bundle "forgotten" dependencies into a single PR to be dealt with at a convenient time for the owner.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2024

CLA assistant check
All committers have signed the CLA.

@mzglinski mzglinski force-pushed the match-release-age branch from 8da0581 to 6249c3f Compare July 24, 2024 22:34
@mzglinski mzglinski force-pushed the match-release-age branch from 6249c3f to 444a7b1 Compare July 24, 2024 22:35
@RahulGautamSingh

This comment was marked as resolved.

@RahulGautamSingh RahulGautamSingh added the auto:discussion-first This PR needs to be preceded by a GitHub Discussion label Jul 24, 2024
Copy link
Contributor

Please create a GitHub Discussion before continuing with this PR.

Thank you for your PR, but we need to discuss the requirements and implementation first.

The maintainers believe that there is a lack of - or misalignment of - requirements about this PR. We need to discuss the requirements and implementation first so that you don't write code that won't be merged.

This PR will be closed for now to avoid confusion, but you can reopen it after the discussion has been resolved.

Thanks, the Renovate team

@github-actions github-actions bot closed this Jul 24, 2024
@mzglinski
Copy link
Author

@RahulGautamSingh I do not believe it is the same. minimumReleaseAge allows to wait for X amount of time before creating a PR. My suggestion allows (for example) to group new releases of packages of which the releaseTimestamp is older than one month.

Example scenario: A few major packages are released, and the owner of the repository is not ready to update the project as of this moment, unfortunately, they decide to do nothing with the PR (no new rules, to hold the version, no stop-updating label etc), and just let it hang. those PRs are updated after every change made to the default branch. Generating noise and consuming CI resources. With the above matcher, I can specify (in the default config that our org uses), to group such updates into single PR.

@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Jul 24, 2024

Got it. Please create a discussion with your points first, as we like a discussion first before creating a PR for a feature like this one.
Once the maintainers comment/approve your idea, you can reopen this PR.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto:discussion-first This PR needs to be preceded by a GitHub Discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants