Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conan): Add support for lockfile maintenance #28174

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

TobiaszSML
Copy link

Changes

This PR introduce lockfile maintenance support for Conan.
It runs conan lock create conanfile.* --lockfile="" for the corresponding updated conanfile, which should be enough to bump all locked dependencies to the most up to date version.

Context

This PR resolves #21912

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2024

CLA assistant check
All committers have signed the CLA.

@TobiaszSML TobiaszSML marked this pull request as draft March 28, 2024 19:51
lib/modules/manager/conan/readme.md Show resolved Hide resolved
lib/modules/manager/conan/artifacts.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/conan/readme.md Outdated Show resolved Hide resolved
@TobiaszSML TobiaszSML marked this pull request as ready for review April 11, 2024 07:35
@TobiaszSML
Copy link
Author

@viceice @rarkins Can you review this PR?

@viceice viceice self-requested a review April 12, 2024 12:50
@rarkins
Copy link
Collaborator

rarkins commented Apr 16, 2024

@TobiaszSML unfortunately not unless #28174 (comment) is resolved

@TobiaszSML
Copy link
Author

@rarkins #28174 is resolved.

@TobiaszSML TobiaszSML requested review from rarkins and viceice May 13, 2024 12:15
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce debug to trace log level

lib/modules/manager/conan/artifacts.ts Outdated Show resolved Hide resolved
@TobiaszSML TobiaszSML force-pushed the feat/21912-conan-lock-file-support branch from 817ca40 to dd4b97b Compare February 6, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conan lock file support
5 participants