feat: eslint-plugin-node to eslint-plugin-n

[aladdin-add]

it was forked from eslint-plugin-node v11.1.0. as the original repository seems no longer maintained.

repo link: github.com/eslint-community/eslint-plugin-n
npm link: https://www.npmjs.com/package/eslint-plugin-n
related discussion: mysticatea/eslint-plugin-node#300

Changes

Context

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[CLAassistant]

All committers have signed the CLA.

[rarkins]

Please provide some links/references

[aladdin-add]

yes, it's just a wip. will provide more info and sign the cla later.

[voxpelli]

I guess one challenge here is that eg the eslint rules are renamed from node/ to n/ and the plugins and/or extends of an eslint config also needs to reflect the new name

Can this be handled?

[viceice]

I guess one challenge here is that eg the eslint rules are renamed from node/ to n/ and the plugins and/or extends of an eslint config also needs to reflect the new name

Can this be handled?

no

[voxpelli]

no

Then sadly I think this isn't possible to do right now.

Would be nice if one could eg. show a replacement suggestion in the Dashboard issue, like:

### Unmaintained dependencies with community replacements:

* `eslint-plugin-node` has been superseded by `eslint-plugin-n`

[viceice]

renovate should simply open the replacement PR and let a maintainer fix the migration needed.

[voxpelli]

The name got a bit mixed up with npm-run-all 😜

[voxpelli]

renovate should simply open the replacement PR and let a maintainer fix the migration needed.

@viceice That assumes that people's tests will fail so that they realize that they need to do additional manual changes

To make matters even worse: If they are using a shared ESLint config, then it might not even be they who should make the change, it should be the upstream

[aladdin-add]

updated the OP, and signed the CLA.🎉

[aladdin-add]

That assumes that people's tests will fail so that they realize that they need to do additional manual changes

Can you give an example of a situation where a ci won't fail?🤔

[voxpelli]

That assumes that people's tests will fail so that they realize that they need to do additional manual changes

Can you give an example of a situation where a ci won't fail?🤔

When there is no CI :) Not everyone runs their ESLint on CI

[viceice]

That assumes that people's tests will fail so that they realize that they need to do additional manual changes

Can you give an example of a situation where a ci won't fail?🤔

When there is no CI :) Not everyone runs their ESLint on CI

that's not renovate's fault. renovate won't automerge r placements by default, so it's the developer who is responsible to check required changes before merging such PRs.

[voxpelli]

Lets try it then and see what the feedback is, would be great to get people moving to it 👍

[viceice]

please don't force-push in future, we're doing squash merge

[voxpelli]

@aladdin-add Can you maybe update the title of this PR to refer to eslint- instead of npm- as well? Then eg. a straight up squash commit will have the correct wording

[aladdin-add]

my bad! 😅 updated~

[HonkingGoose]

Small style change to the preset name maybe?

[HonkingGoose]

This approval is only for the text content. 😉

I'll leave it to the maintainers to approve this preset, and to review if this fork is the best replacement.

[voxpelli]

if this fork is the best replacement

Some added context here that may be helpful for them:

This is the fork that's maintained by the official ESLint Community – a home for high-value projects in the ESLint ecosystem where the ESLint community collectively can ensure that they continue to be maintained instead of eg. relying on any single maintainer / releaser.

[aladdin-add]

friendly ping...

[rarkins]

So I think we confirmed:

• Old package is unmaintained
• New package is legitimate

But is there a problem if this PR breaks people's scripts due to migration being necessary?

[viceice]

I think we should limit current version to ^11.1.0, so only if a user is on latest eslint-plugin-node major then open a replacement PR? Otherwise we suggest updates to older versions too, even if the user disabled majors.

[viceice]

still conflicted

[aladdin-add]

still conflicted

should be addressed now.

[renovate-release]

🎉 This PR is included in version 37.256.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)
• 37.256.0

Your semantic-release bot 📦🚀